Skip to content

Add tutorials overview and TOC #2978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

frankharkins
Copy link
Member

@frankharkins frankharkins commented Apr 11, 2025

Also adds a script to check the page is valid.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep it simple, I decided not to parse into a markdown AST because this script is specific to this page and we can expect a certain structure. Here's an example of it catching both types of error:

Screenshot 2025-04-11 at 11 03 24

Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I'll review the rest soon

We're not adding hello world in this first iteration
Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script looks great! Good call to simplify it by relying on the assumptions we expect for that file

github-merge-queue bot pushed a commit that referenced this pull request Apr 15, 2025
#2965 added support to spellcheck TOCs, but this has the side-effect of
also checking URLs.

Unfortunately, there are some words that are valid in a URL but
shouldn't be added to the dictionary as they're not valid elsewhere. One
example of this is `grovers`; usually this should be corrected to
`Grover's`, but it _is_ valid in a URL.

Since we can't add file-level ignores in the `_toc.json`, I think the
best approach is to ignore these URLs using a regex.

This is not a problem on `main`, but it's blocking CI in #2978.

## Browse tutorials by tool

Simple text to explain this tools-based schema
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs copy


## Browse tutorials by topic

Simple text to explain this tools-based schema
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants