-
Notifications
You must be signed in to change notification settings - Fork 99
Add tutorials overview and TOC #2978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e59a8a6
to
82c3099
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I'll review the rest soon
We're not adding hello world in this first iteration
…H/tutorials-navigation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script looks great! Good call to simplify it by relying on the assumptions we expect for that file
#2965 added support to spellcheck TOCs, but this has the side-effect of also checking URLs. Unfortunately, there are some words that are valid in a URL but shouldn't be added to the dictionary as they're not valid elsewhere. One example of this is `grovers`; usually this should be corrected to `Grover's`, but it _is_ valid in a URL. Since we can't add file-level ignores in the `_toc.json`, I think the best approach is to ignore these URLs using a regex. This is not a problem on `main`, but it's blocking CI in #2978.
…H/tutorials-navigation
|
||
## Browse tutorials by tool | ||
|
||
Simple text to explain this tools-based schema |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs copy
|
||
## Browse tutorials by topic | ||
|
||
Simple text to explain this tools-based schema |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also here
Also adds a script to check the page is valid.