-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add qiskit aer guide #302
add qiskit aer guide #302
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@javabster GitHub doesn't display which lines your comments refer (see screenshot below) but I guessed and addressed them. |
@kevinsung if you click on the purple "ReviewNB" button you should be able to see which lines my comments apply to :D |
Overall looks great, @abbycross or @beckykd would you mind doing a quick pass at a language review? You always end up catching typos etc that I miss 😅 |
@kevinsung what magic do you do to skip/unskip checks? 😆 I wanted to turn the preview/setup back on so that I can read through the preview. |
Would you like me to add this to the table of contents for Verify @kevinsung? |
I didn't do anything to intentionally skip those checks. I don't know why they were skipped.
I'll do it.
For context, Abby M and I chose that title originally but in writing the content, I felt it was better to show both exact and noisy simulation, so I updated the title accordingly. |
I've addressed all the comments. In updating the TOC, I also went ahead and reordered and renamed some of the other pages according to the plan outlined at #17 |
|
Eric said it's because submitted the PR from a fork. In the future, I'll stop using my fork and just use this repository directly. Do you need me to do it now or can I leave this PR as is? |
No need to change it now -- I can view a preview locally. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Fixes Qiskit#291 --------- Co-authored-by: abbycross <across@us.ibm.com>
Fixes #291