Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add qiskit aer guide #302

Merged
merged 13 commits into from
Nov 13, 2023
Merged

add qiskit aer guide #302

merged 13 commits into from
Nov 13, 2023

Conversation

kevinsung
Copy link
Collaborator

Fixes #291

@kevinsung kevinsung requested a review from javabster November 8, 2023 15:46
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@kevinsung
Copy link
Collaborator Author

@javabster GitHub doesn't display which lines your comments refer (see screenshot below) but I guessed and addressed them.

image

@javabster
Copy link
Collaborator

@kevinsung if you click on the purple "ReviewNB" button you should be able to see which lines my comments apply to :D

@javabster
Copy link
Collaborator

Overall looks great, @abbycross or @beckykd would you mind doing a quick pass at a language review? You always end up catching typos etc that I miss 😅

@abbycross
Copy link
Collaborator

@kevinsung what magic do you do to skip/unskip checks? 😆 I wanted to turn the preview/setup back on so that I can read through the preview.

@abbycross
Copy link
Collaborator

Would you like me to add this to the table of contents for Verify @kevinsung?
@javabster are you good with the title as it is, or should we change to what you have in the docs box note: "Noisy simulation with Qiskit Aer"?

@kevinsung
Copy link
Collaborator Author

@kevinsung what magic do you do to skip/unskip checks? 😆 I wanted to turn the preview/setup back on so that I can read through the preview.

I didn't do anything to intentionally skip those checks. I don't know why they were skipped.

Would you like me to add this to the table of contents for Verify @kevinsung?

I'll do it.

@javabster are you good with the title as it is, or should we change to what you have in the docs box note: "Noisy simulation with Qiskit Aer"?

For context, Abby M and I chose that title originally but in writing the content, I felt it was better to show both exact and noisy simulation, so I updated the title accordingly.

@kevinsung
Copy link
Collaborator Author

I've addressed all the comments. In updating the TOC, I also went ahead and reordered and renamed some of the other pages according to the plan outlined at #17

@abbycross
Copy link
Collaborator

@kevinsung what magic do you do to skip/unskip checks? 😆 I wanted to turn the preview/setup back on so that I can read through the preview.
I'm asking @Eric-Arellano if he knows how this happens and how to change it

@javabster javabster added this to the 23-11-29 dec release milestone Nov 13, 2023
@kevinsung
Copy link
Collaborator Author

@kevinsung what magic do you do to skip/unskip checks? 😆 I wanted to turn the preview/setup back on so that I can read through the preview.
I'm asking @Eric-Arellano if he knows how this happens and how to change it

Eric said it's because submitted the PR from a fork. In the future, I'll stop using my fork and just use this repository directly. Do you need me to do it now or can I leave this PR as is?

@abbycross
Copy link
Collaborator

@kevinsung what magic do you do to skip/unskip checks? 😆 I wanted to turn the preview/setup back on so that I can read through the preview.
I'm asking @Eric-Arellano if he knows how this happens and how to change it

Eric said it's because submitted the PR from a fork. In the future, I'll stop using my fork and just use this repository directly. Do you need me to do it now or can I leave this PR as is?

No need to change it now -- I can view a preview locally. Thanks!

Copy link
Collaborator

@abbycross abbycross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kevinsung kevinsung merged commit 166dbca into Qiskit:main Nov 13, 2023
@kevinsung kevinsung deleted the qiskit-aer branch November 13, 2023 17:49
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Fixes Qiskit#291

---------

Co-authored-by: abbycross <across@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ NEW PAGE ] Noisy simulation with Qiskit Aer primitives
3 participants