Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audited and improved existing metadata for main docs pages #345

Merged
merged 6 commits into from
Nov 16, 2023

Conversation

javabster
Copy link
Collaborator

closes #131

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thanks so much Abby.

@@ -1301,7 +1301,7 @@
"metadata": {
"anaconda-cloud": {},
"celltoolbar": "Tags",
"description": "Plotting data in Qiskit notebook",
"description": "Create visualisations of circuits and plot job data using the Qiskit visualization module ",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love that we have both a British and an American version of the spelling here 😆 I wonder if it's useful to keep it as-is to turn up more in searches? Google must account for this kind of variety in spelling, right?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IBM's style guide says to use American spelling hah

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omg you can really tell im going through an identity crisis 😆

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

Screenshot 2023-11-14 at 1 45 15 PM

Copy link
Collaborator

@abbycross abbycross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to go once the metadata has been fixed to match the title in circuit-library (see #345 (comment)), so approving!

Co-authored-by: abbycross <across@us.ibm.com>
@javabster javabster merged commit d978ad8 into main Nov 16, 2023
@javabster javabster deleted the update-metadata branch November 16, 2023 15:30
frankharkins pushed a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
closes Qiskit#131

---------

Co-authored-by: abbycross <across@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the metadata for each page
3 participants