Skip to content

Conversation

@kcmccormibm
Copy link
Collaborator

No description provided.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@qiskit-bot
Copy link
Contributor

Thanks for contributing to Qiskit documentation!

Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌

@kcmccormibm kcmccormibm requested a review from kaelynj October 22, 2025 17:55
Copy link
Collaborator

@kaelynj kaelynj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! 🚀

@kcmccormibm kcmccormibm requested a review from abbycross October 24, 2025 15:33
@abbycross
Copy link
Collaborator

I'd love to do a quick copyedit if you can hold off merging for a bit?

@abbycross abbycross marked this pull request as draft October 24, 2025 15:43
"To set up and install the packages above, see the [Install Qiskit](/docs/guides/install-qiskit) guide.\n",
"In order to run jobs on real quantum computers, students will need to set up an account with IBM Quantum® by following the steps in the [Set up your IBM Cloud account](/docs/guides/cloud-setup) guide.\n",
"\n",
"This module was tested and used 2 seconds of QPU time. This is an estimate only. Your actual usage may vary."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add which processor it took 2 seconds on? e.g.,

"This module was tested and used 2 seconds of QPU time on a Heron v2 processor."

@kcmccormibm
Copy link
Collaborator Author

I'd love to do a quick copyedit if you can hold off merging for a bit?

yep, thank you!

"source": [
"## Introduction\n",
"\n",
"In the Qiskit in the Classroom modules, you'll have the opportunity to use a quantum computer to explore various concepts in quantum computing-adjacent fields such as quantum mechanics, computer science, chemistry, and more. To prepare you for this, we've made this introductory module, which teaches the fundamentals of quantum computing and how to use Qiskit to run quantum circuits.\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"In the Qiskit in the Classroom modules, you'll have the opportunity to use a quantum computer to explore various concepts in quantum computing-adjacent fields such as quantum mechanics, computer science, chemistry, and more. To prepare you for this, we've made this introductory module, which teaches the fundamentals of quantum computing and how to use Qiskit to run quantum circuits.\n",
"In the Qiskit in the Classroom modules, you'll have the opportunity to use a quantum computer to explore various concepts in quantum computing-adjacent fields such as quantum mechanics, computer science, chemistry, and more. This module serves as a prerequisite to the others - it introduces the fundamentals of quantum computing and how to use Qiskit to run quantum circuits.\n",

I was trying to work around using the "this" in "To prepare you for this" since it's vague - but is "prerequisite" the right word?

"\n",
"### Fundamental operations: gates\n",
"\n",
"Now, a computer needs to be able to *do* something with the bits in order to, well, compute. Binary gates are the operations that form the fundamental building blocks of all more complicated algorithms and codes.\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Now, a computer needs to be able to *do* something with the bits in order to, well, compute. Binary gates are the operations that form the fundamental building blocks of all more complicated algorithms and codes.\n",
"Now, a computer needs to be able to *do* something with the bits in order to, well, compute. Binary gates are the operations that form the fundamental building blocks of all the more complicated algorithms and codes.\n",

"\n",
"### Measurements:\n",
"\n",
"Typically, when learning about classical computing, not much attention is paid to the process of reading out the state of the bits. This is because there's not much to it from a conceptual perspective. You can measure the bits at anytime before, during, or after a computation, and it doesn't affect the outcome. This is not the case in quantum computing, as we will discuss below.\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Typically, when learning about classical computing, not much attention is paid to the process of reading out the state of the bits. This is because there's not much to it from a conceptual perspective. You can measure the bits at anytime before, during, or after a computation, and it doesn't affect the outcome. This is not the case in quantum computing, as we will discuss below.\n",
"Typically, when learning about classical computing, not much attention is paid to the process of reading out the state of the bits. This is because it's not very complex from a conceptual perspective. You can measure the bits at anytime before, during, or after a computation, and it doesn't affect the outcome. This is not the case in quantum computing, as we will discuss below.\n",

"\n",
"![Classical circuit diagram for the half-adder circuit. An XOR gate generates the Sum output bit and an AND gate generates the Carry output bit.](/learning/images/modules/quantum-mechanics/getting-started-with-qiskit/classicaladder.avif)\n",
"\n",
"So, the two bits are copied and fed through both an AND gate and an XOR gate. The result of the XOR gate is the \"sum bit\" (S), which remains in the ones place of the binary number, and the result of the AND gate is the \"carry bit\" (C) which is the value of the next most significant digit in the binary number. Here is the truth table:\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"So, the two bits are copied and fed through both an AND gate and an XOR gate. The result of the XOR gate is the \"sum bit\" (S), which remains in the ones place of the binary number, and the result of the AND gate is the \"carry bit\" (C) which is the value of the next most significant digit in the binary number. Here is the truth table:\n",
"So, the two bits are copied and fed through both an AND gate and an XOR gate. The result of the XOR gate is the \"sum bit\" (S), which remains in the ones place of the binary number, and the result of the AND gate is the \"carry bit\" (C), which is the value of the next most significant digit in the binary number. Here is the truth table:\n",

Comment on lines +377 to +378
"| $|0\\rangle$ | $|1\\rangle$ |\n",
"| $|1\\rangle$ | $|0\\rangle$ |\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"| $|0\\rangle$ | $|1\\rangle$ |\n",
"| $|1\\rangle$ | $|0\\rangle$ |\n",
"| $\\vert 0\\rangle$ | $\\vert 1\\rangle$ |\n",
"| $\\vert 1\\rangle$ | $\\vert 0\\rangle$ |\n",

This wasn't rendering properly - I think it was missing the verts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

4 participants