Skip to content

Conversation

@frankharkins
Copy link
Member

@frankharkins frankharkins commented Nov 24, 2025

Part of #4200

Looking at the broken links, the vast majority have a period (.) in their anchors because they're links to members of an object.

  • One example is /docs/api/qiskit-c/qk-bit-term#qk_bitterm_label.bit_term. The part after the period is a parameter of the function qk_bitterm_label. Parameters don't have HTML anchors, hence the broken link.
  • Another example is /docs/api/qiskit-c/qk-circuit#qkdelayunit.qkdelayunit_ms, a value of QkDelayUnit. This enum value does have an anchor, but due to our conversion script, the anchor is #enumerator-qkdelayunit_ms.

This PR fixes this by mapping such links to their parent objects. This fixes 220/236 links. While it would be nice to be able to link directly to the members, it's going to be quite a lot of work. Mapping to the parent object is very simple (see 02758e8), and will take the user very close to the memeber.

I regenerated all APIs to make sure this didn't break any other links (it fixed two links in qiskit-c v2.1). I will continue investigating the other 16 broken links.

npm run regen-apis
git restore public/**/*.avif --source ad25290
@frankharkins frankharkins marked this pull request as ready for review November 24, 2025 17:56
Copy link
Collaborator

@arnaucasau arnaucasau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work with this, Frank! I updated the PR description to link to #4200 :)

frankharkins and others added 2 commits November 25, 2025 12:09
Co-authored-by: Arnau Casau <47946624+arnaucasau@users.noreply.github.com>
@frankharkins frankharkins added this pull request to the merge queue Nov 25, 2025
Merged via the queue into main with commit 927351c Nov 25, 2025
3 checks passed
@frankharkins frankharkins deleted the FH/c-objects-inv-links branch November 25, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants