Handle historical Qiskit versions with GitHub source links #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
commented
Jan 18, 2024
|
|
||
| let slug: string; | ||
| let version: string; | ||
| if ( |
There was a problem hiding this comment.
Matt T reviewed the if statements to make sure this covers all the import paths.
| } | ||
| } | ||
|
|
||
| const QISKIT_METAPACKAGE_TO_TERRA = new Map([ |
There was a problem hiding this comment.
These versions come from https://docs.quantum.ibm.com/api/qiskit/release-notes/0.44. I double checked them and tried to be careful - I don't think you need to spend the time rechecking.
Eric-Arellano
commented
Jan 18, 2024
Comment on lines
+189
to
+193
| return (fileName) => | ||
| determineHistoricalQiskitGithubUrl( | ||
| this.versionWithoutPatch, | ||
| normalizeFile(fileName), | ||
| ); |
There was a problem hiding this comment.
This pattern is really neat. We're using partial application. We want to return a function (string) => string, but we need to pass in the extra argument metapackageVersion for it to work.
arnaucasau
approved these changes
Jan 19, 2024
frankharkins
pushed a commit
to frankharkins/documentation
that referenced
this pull request
Jul 22, 2024
Part of Qiskit#454. Historical versions of Qiskit docs are tricky because of qiskit-metapackage referring to multiple distinct GitHub repositories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #454. Historical versions of Qiskit docs are tricky because of qiskit-metapackage referring to multiple distinct GitHub repositories.