Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add headers for exceptions #713

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Add headers for exceptions #713

merged 2 commits into from
Jan 26, 2024

Conversation

frankharkins
Copy link
Member

@frankharkins frankharkins commented Jan 26, 2024

Quick fix to use the same logic for functions and exceptions. Closes #712.

A known problem with this implementation is that some headings should not be h3, but it depends on the page. See #714.

Copy link
Collaborator

@Eric-Arellano Eric-Arellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💜

@frankharkins frankharkins added this pull request to the merge queue Jan 26, 2024
Merged via the queue into main with commit 4381020 Jan 26, 2024
5 checks passed
@frankharkins frankharkins deleted the FH/exception-headings branch January 26, 2024 15:36
frankharkins added a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
Quick fix to use the same logic for functions and exceptions. Closes
Qiskit#712.

A known problem with this implementation is that some headings should
not be `h3`, but it depends on the page. See
Qiskit#714.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Exceptions are missing headers in API docs
2 participants