Improve file filtering in CI #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scripts/nb-tester/test-notebook.py
Outdated
| @@ -35,6 +35,36 @@ | |||
| ] | |||
|
|
|||
|
|
|||
| def filter_paths(paths: list[Path], submit_jobs: bool) -> list[Path]: | |||
There was a problem hiding this comment.
Nicer is to return Iterator[Path]. Every time you want to return a path, you will yield path. No need to have good_paths as a collection - remove that. No return statement.
Lines 21 to 29 in ff3500a
There was a problem hiding this comment.
Much nicer, thanks!
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Merged
Eric-Arellano
approved these changes
Jan 31, 2024
frankharkins
added a commit
to frankharkins/documentation
that referenced
this pull request
Jul 22, 2024
The `transpiler-stages` notebook is broken, but will be tested in CI any time someone edits it (even if just changing copy etc.). This breaks PRs that are perfectly fine. This PR ignores excluded files completely. I also took the opportunity to: - improve the code readability somewhat (i.e. less `path for path in paths if path`), - print a message when notebooks are skipped, otherwise someone running `tox` locally might believe their notebook was fine even though it never ran. --------- Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
transpiler-stagesnotebook is broken, but will be tested in CI any time someone edits it (even if just changing copy etc.). This breaks PRs that are perfectly fine.This PR ignores excluded files completely. I also took the opportunity to:
path for path in paths if path),toxlocally might believe their notebook was fine even though it never ran.