Add integration test of qiskit-sphinx-theme #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Arellano
force-pushed
the
EA/integration-test
branch
from
8a77ac6 to
3b21960
Compare
arnaucasau
reviewed
Mar 5, 2024
Co-authored-by: Arnau Casau <47946624+arnaucasau@users.noreply.github.com>
arnaucasau
approved these changes
Mar 5, 2024
frankharkins
pushed a commit
to frankharkins/documentation
that referenced
this pull request
Jul 22, 2024
Closes Qiskit#715. This is useful generally for better testing of our conversion pipeline, as it's our only test that tests the entire conversion pipeline. It also is useful to allow us to easily compare Sphinx's behavior vs. our app's behavior, like the PDFs I uploaded in Qiskit#947. -- I didn't document this in the README because we don't talk about testing in the README currently. Our README is already quite long, so I was hesitant to add to it since most technical writers don't care about testing, unlike Jupyter notebook testing that we do document. Instead, I documented the test file itself. I'm not sure if this is clear enough. --------- Co-authored-by: Arnau Casau <47946624+arnaucasau@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #715.
This is useful generally for better testing of our conversion pipeline, as it's our only test that tests the entire conversion pipeline.
It also is useful to allow us to easily compare Sphinx's behavior vs. our app's behavior, like the PDFs I uploaded in #947.
--
I didn't document this in the README because we don't talk about testing in the README currently. Our README is already quite long, so I was hesitant to add to it since most technical writers don't care about testing, unlike Jupyter notebook testing that we do document.
Instead, I documented the test file itself. I'm not sure if this is clear enough.