Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add separate_circuit, qpd_roundtrip test, and observable utils #145

Merged
merged 13 commits into from
May 12, 2023
Merged

Add separate_circuit, qpd_roundtrip test, and observable utils #145

merged 13 commits into from
May 12, 2023

Conversation

caleb-johnson
Copy link
Collaborator

@caleb-johnson caleb-johnson commented May 7, 2023 •
edited by garrison
Loading

@caleb-johnson caleb-johnson mentioned this pull request May 7, 2023
Closed
2 tasks
@caleb-johnson caleb-johnson added the cutting QPD-based circuit cutting code label May 7, 2023
@coveralls
Copy link

coveralls commented May 7, 2023 •
edited by github-actions bot
Loading

Pull Request Test Coverage Report for Build 4957727951

  • 265 of 265 (100.0%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.5%) to 88.076%
Totals Coverage Status
Change from base Build 4953731243: 1.5%
Covered Lines: 2046
Relevant Lines: 2323
💛 - Coveralls

@caleb-johnson caleb-johnson added the on hold Let's wait for something before merging label May 7, 2023
@caleb-johnson caleb-johnson changed the title Create a module for handling observables in cutting Add separate_circuit, qpd_roundtrip test, and observable utils May 8, 2023
@caleb-johnson caleb-johnson added qpd Related to quasi-probability decompositions and removed cutting QPD-based circuit cutting code labels May 8, 2023
@garrison garrison mentioned this pull request May 8, 2023
Open
caleb-johnson and others added 9 commits May 11, 2023 19:13
@caleb-johnson
Add a separate_circuit function + tests
a8aa265
@caleb-johnson
Begin PR for separate_circuit
97448af
@caleb-johnson
updates to init and test
4fc697b
@caleb-johnson @garrison
@anedumla @Cryoris @eggerdj @stefan-woerner @jenglick @pedrorrivero @BryceFuller
observable_estimation module
f80386d 
Co-authored-by: Jim Garrison <jim@garrison.cc>
Co-authored-by: Almudena Carrera Vazquez <acv@zurich.ibm.com>
Co-authored-by: Julien Gacon <jules.gacon@googlemail.com>
Co-authored-by: Daniel Egger <38065505+eggerdj@users.noreply.github.com>
Co-authored-by: Stefan Woerner <WOR@zurich.ibm.com>
Co-authored-by: Jen Glick <41485571+jenglick@users.noreply.github.com>
Co-authored-by: Pedro Rivero Ramirez <pedro.rivero.ramirez@gmail.com>
Co-authored-by: Bryce Fuller <bgf024@gmail.com>
@caleb-johnson
Add iteration util and tests
6fa61d9
@caleb-johnson
Dont take circuits into process_outcomes
ccffc76
@caleb-johnson
Pull out non-util functionality from observable grouping module
fbef7af
@caleb-johnson
Move simulation out to general utils
dba34fc
@caleb-johnson
Fix import errors
14974a0
@caleb-johnson caleb-johnson force-pushed the observable-collection branch from ab0ac2f to 14974a0 Compare May 12, 2023 00:21
@caleb-johnson caleb-johnson requested a review from garrison May 12, 2023 00:26
@caleb-johnson caleb-johnson removed the on hold Let's wait for something before merging label May 12, 2023
@caleb-johnson @garrison
Update circuit_knitting_toolbox/utils/observable_grouping.py
850e3d5 
Co-authored-by: Jim Garrison <garrison@ibm.com>
This was referenced May 12, 2023
Open
Closed
garrison
garrison approved these changes May 12, 2023
View reviewed changes
Copy link
Member

@garrison garrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

@caleb-johnson caleb-johnson merged commit 9fdf687 into main May 12, 2023
@caleb-johnson caleb-johnson deleted the observable-collection branch May 12, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garrison garrison garrison approved these changes

Assignees
No one assigned
Labels
qpd Related to quasi-probability decompositions
Projects
None yet
Milestone
0.2.0-pre1 - Create a package for con...
3 participants
@caleb-johnson @coveralls @garrison