Provide a workaround to #422, Sampler failing when no measurements #426

garrison · 2023-09-29T18:53:33Z

Temporary workaround to #422.

Needs

a test

CLAassistant · 2023-10-03T22:56:27Z

All committers have signed the CLA.

ibrahim-shehzad · 2023-10-04T02:41:19Z

I added a test, @garrison, in test_cutting_roundtrip.py, called test_sampler_fail.

With this, the current PR will touch one fewer file

caleb-johnson

Will these circuits with 1 measurement be ignored during reconstruction, since they don't actually have non-trivial observables associated with them?

caleb-johnson · 2023-10-05T14:21:47Z

circuit_knitting/cutting/cutting_experiments.py

+    # measure one qubit as a temporary workaround to
+    # https://github.com/Qiskit-Extensions/circuit-knitting-toolbox/issues/422
+    pauli_indices = cog.pauli_indices
+    if not pauli_indices:


What can pauli_indices be here? Should we just explicitly state what we expect? (e.g. if pauli_indices == [])

Or we could just assert pauli_indices == [] inside the if? (assuming an empty list is what is returned in I observable case)

What can pauli_indices be here? Should we just explicitly state what we expect? (e.g. if pauli_indices == [])

It's a sequence of ints. It contains the qubit indices that need to be measured.

The choice of style here is influenced by PEP 8:

For sequences, (strings, lists, tuples), use the fact that empty sequences are false:

# Correct: if not seq: if seq:

# Wrong: if len(seq): if not len(seq):

The "nice" thing about doing it this way is it doesn't matter what type the sequence is. For instance, if it were to be a tuple of indices, then it will still behave correctly with the current code, but it would not if we were to compare with [] because () != [].

nice, thanks for explanation

Wow, this is more profound than I thought. Nice!

garrison · 2023-10-05T21:05:36Z

Will these circuits with 1 measurement be ignored during reconstruction, since they don't actually have non-trivial observables associated with them?

Yes

caleb-johnson

LGTM 👍

Thanks @IbrahimShehzad and @garrison !

garrison · 2023-10-09T17:47:12Z

I am leaning toward waiting first until #434 is merged and then updating this branch accordingly.

EDIT: Actually, I might have changed my mind already. 😂

test/cutting/test_cutting_roundtrip.py

Co-authored-by: Jim Garrison <garrison@ibm.com>

ibrahim-shehzad

Everything now looks good to me. Thanks.

) * Provide a workaround to #422, Sampler failing when no measurements * Add test for workaround to Issue #422. * Redo previous commit after running tox. * Fix tox error from previous build. * Fix tox error from last build. * Un-modify the metadata in a notebook With this, the current PR will touch one fewer file * Update test/cutting/test_cutting_roundtrip.py Co-authored-by: Jim Garrison <garrison@ibm.com> * Update test/cutting/test_cutting_roundtrip.py Co-authored-by: Jim Garrison <garrison@ibm.com> * black --------- Co-authored-by: Ibrahim <ibrahim.shehzad@ibm.com> Co-authored-by: Ibrahim Shehzad <75153717+Ibrahim-Shehzad@users.noreply.github.com> (cherry picked from commit f596307)

) (#436) * Provide a workaround to #422, Sampler failing when no measurements * Add test for workaround to Issue #422. * Redo previous commit after running tox. * Fix tox error from previous build. * Fix tox error from last build. * Un-modify the metadata in a notebook With this, the current PR will touch one fewer file * Update test/cutting/test_cutting_roundtrip.py Co-authored-by: Jim Garrison <garrison@ibm.com> * Update test/cutting/test_cutting_roundtrip.py Co-authored-by: Jim Garrison <garrison@ibm.com> * black --------- Co-authored-by: Ibrahim <ibrahim.shehzad@ibm.com> Co-authored-by: Ibrahim Shehzad <75153717+Ibrahim-Shehzad@users.noreply.github.com> (cherry picked from commit f596307) Co-authored-by: Jim Garrison <garrison@ibm.com>

Provide a workaround to #422, Sampler failing when no measurements

9443b8a

garrison added the cutting QPD-based circuit cutting code label Sep 29, 2023

garrison added this to the 0.4.1 milestone Sep 29, 2023

garrison added the stable backport potential Suitable to be backported to most recent stable branch by Mergify label Sep 29, 2023

Add test for workaround to Issue #422.

eadcf2c

ibrahim-shehzad added 3 commits October 3, 2023 21:12

Redo previous commit after running tox.

0609cee

Fix tox error from previous build.

b77f362

Fix tox error from last build.

0575fbb

ibrahim-shehzad marked this pull request as ready for review October 4, 2023 02:48

ibrahim-shehzad requested a review from caleb-johnson October 5, 2023 01:11

Un-modify the metadata in a notebook

2853f2c

With this, the current PR will touch one fewer file

caleb-johnson reviewed Oct 5, 2023

View reviewed changes

caleb-johnson previously approved these changes Oct 5, 2023

View reviewed changes

garrison commented Oct 9, 2023

View reviewed changes

test/cutting/test_cutting_roundtrip.py Outdated Show resolved Hide resolved

garrison commented Oct 9, 2023

View reviewed changes

test/cutting/test_cutting_roundtrip.py Outdated Show resolved Hide resolved

ibrahim-shehzad dismissed caleb-johnson’s stale review via 4d28704 October 9, 2023 19:03

ibrahim-shehzad and others added 3 commits October 9, 2023 15:03

Update test/cutting/test_cutting_roundtrip.py

4d28704

Co-authored-by: Jim Garrison <garrison@ibm.com>

Update test/cutting/test_cutting_roundtrip.py

60830a7

Co-authored-by: Jim Garrison <garrison@ibm.com>

black

930b51e

ibrahim-shehzad reviewed Oct 9, 2023

View reviewed changes

garrison merged commit f596307 into main Oct 10, 2023
10 checks passed

garrison deleted the measurementless-circuit-workaround branch October 10, 2023 01:27

mergify bot mentioned this pull request Oct 10, 2023

Provide a workaround to #422, Sampler failing when no measurements (backport #426) #436

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Provide a workaround to #422, Sampler failing when no measurements #426

Provide a workaround to #422, Sampler failing when no measurements #426

garrison commented Sep 29, 2023 •

edited by ibrahim-shehzad

Loading

CLAassistant commented Oct 3, 2023 •

edited

Loading

ibrahim-shehzad commented Oct 4, 2023

caleb-johnson left a comment

caleb-johnson Oct 5, 2023 •

edited

Loading

garrison Oct 5, 2023

caleb-johnson Oct 5, 2023

ibrahim-shehzad Oct 6, 2023 •

edited

Loading

garrison commented Oct 5, 2023

caleb-johnson left a comment

garrison commented Oct 9, 2023 •

edited

Loading

ibrahim-shehzad left a comment

Provide a workaround to #422, Sampler failing when no measurements #426

Provide a workaround to #422, Sampler failing when no measurements #426

Conversation

garrison commented Sep 29, 2023 • edited by ibrahim-shehzad Loading

CLAassistant commented Oct 3, 2023 • edited Loading

ibrahim-shehzad commented Oct 4, 2023

caleb-johnson left a comment

Choose a reason for hiding this comment

caleb-johnson Oct 5, 2023 • edited Loading

Choose a reason for hiding this comment

garrison Oct 5, 2023

Choose a reason for hiding this comment

caleb-johnson Oct 5, 2023

Choose a reason for hiding this comment

ibrahim-shehzad Oct 6, 2023 • edited Loading

Choose a reason for hiding this comment

garrison commented Oct 5, 2023

caleb-johnson left a comment

Choose a reason for hiding this comment

garrison commented Oct 9, 2023 • edited Loading

ibrahim-shehzad left a comment

Choose a reason for hiding this comment

garrison commented Sep 29, 2023 •

edited by ibrahim-shehzad

Loading

CLAassistant commented Oct 3, 2023 •

edited

Loading

caleb-johnson Oct 5, 2023 •

edited

Loading

ibrahim-shehzad Oct 6, 2023 •

edited

Loading

garrison commented Oct 9, 2023 •

edited

Loading