Corrected qubits ordering in MPS::sample_measure_using_probabilities. #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merav-aharoni
requested review from
atilag,
chriseclectic and
vvilpas
as code owners
merav-aharoni
changed the title
chriseclectic
added
the
Changelog: Bugfix
|
@merav-aharoni Can you add a release note for the bugfix? |
chriseclectic
added
the
stable-backport-potential
vvilpas
approved these changes
Nov 3, 2020
chriseclectic
pushed a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bug was reported in issue #997. The error was in the ordering of the qubits in sample_measure_using_probabilities.
Details and comments
The correction is to order the qubits before invoking
sample_measure_using_probabilities, because the input qubits are always ordered in advance inqasm_controller.py. See ordering also inapply_measure.