Allow disabling of dependency installation in setup.py #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Some Python dependencies are installed outside regular setuptools installation because are required by compilation of C++ code. Now this installation can be disabled setting the environment variable _DISABLE_DEPENDENCY_INSTALL to 1 or "On". - This commit also adds version checks when setup.py checks if those packages are available.
vvilpas
changed the title
mtreinish
previously approved these changes
Mar 9, 2021
There was a problem hiding this comment.
This LGTM, it might be worth pointing out that newer pip versions shouldn't need this because of the pyproject.toml build requirements outlining these. But it comes up enough that people are calling setup.py directly or using an older pip version that this doesn't work.
My only hesitation here is the additional use of distutils which will be deprecated in python 3.10: https://www.python.org/dev/peps/pep-0632/ they specifically call out strtobool as something we need to implement ourselves (https://www.python.org/dev/peps/pep-0632/#migration-advice ). Maybe for future proofing we do that in a follow up and write our own strtobool
|
I've added our won |
chriseclectic
approved these changes
Mar 30, 2021
mtreinish
added
the
Changelog: New Feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some Python dependencies are installed outside regular
setuptoolsinstallation because are requiredby compilation of C++ code. Now this installation can be disabled setting the environment variable
_DISABLE_DEPENDENCY_INSTALL to 1 or "On".
This commit also adds version checks on those packages when
setup.pychecks if they are already available.Details and comments
Fixes #1128