Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable GPU methods if no device is available #1213

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

vvilpas
Copy link
Contributor

@vvilpas vvilpas commented Apr 7, 2021

Summary

GPU methods are disabled if no device is available. An exception is thrown early in the process if no device is available.

Fixes the deploy failure we had in latest 0.8.0 release.

Details and comments

@mtreinish mtreinish added Changelog: Bugfix Include in the Fixed section of the changelog stable-backport-potential The issue or PR might be minimal and/or import enough to backport to stable labels Apr 7, 2021
@vvilpas
Copy link
Contributor Author

vvilpas commented Apr 7, 2021

I have disabled the GPU methods, when no device is available, throwing an exception in the execute try/catch block.
Given that deploy test passes, @hhorii @doichanj do you see any issues/problems with this approach?

@doichanj
Copy link
Collaborator

doichanj commented Apr 8, 2021

No, I agree with this fix.

@vvilpas
Copy link
Contributor Author

vvilpas commented Apr 8, 2021

Ok. Seems it is working. Reverting deploy.yml to allow merging.

@chriseclectic chriseclectic merged commit 5e8b0ef into Qiskit:master Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the Fixed section of the changelog stable-backport-potential The issue or PR might be minimal and/or import enough to backport to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants