Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow measure sampling with compatible initialize #1219

Merged
merged 2 commits into from
Apr 13, 2021
Merged

Allow measure sampling with compatible initialize #1219

merged 2 commits into from
Apr 13, 2021

Conversation

chriseclectic
Copy link
Member

Summary

If initialize is the first instruction in a circuit, or is defined across the full width of a circuit, it is deterministic and hence is compatible with the measurement sampling optimization

Details and comments

Fixes #1210

@chriseclectic
Allow measure sampling with initialize
16e02fe 
If initialize is the first instruction in a circuit, or is defined across the full width of a circuit, it is deterministic and hence is compatible with the measurement sampling optimization
@chriseclectic chriseclectic added stable-backport-potential The issue or PR might be minimal and/or import enough to backport to stable Changelog: Bugfix Include in the Fixed section of the changelog labels Apr 9, 2021
vvilpas
vvilpas approved these changes Apr 12, 2021
View reviewed changes
Copy link
Contributor

@vvilpas vvilpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
It seems conan-center has some kind of problem and is not reachable right now, making CI fail. Let's see if they solve it soon.

@vvilpas vvilpas merged commit f126651 into Qiskit:master Apr 13, 2021
chriseclectic added a commit that referenced this pull request Apr 14, 2021
@chriseclectic
Allow measure sampling with initialize (#1219)
59612e3 
If initialize is the first instruction in a circuit, or is defined across the full width of a circuit, it is deterministic and hence is compatible with the measurement sampling optimization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vvilpas vvilpas vvilpas approved these changes

@mtreinish mtreinish Awaiting requested review from mtreinish

Assignees
No one assigned
Labels
Changelog: Bugfix Include in the Fixed section of the changelog stable-backport-potential The issue or PR might be minimal and/or import enough to backport to stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AerSimulator(method="statevector") with different performance from StatevectorSimulator
2 participants
@chriseclectic @vvilpas