Fix performance regression from QuantumError.to_dict #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseclectic
added
stable-backport-potential
chriseclectic
requested review from
hhorii,
mtreinish and
vvilpas
as code owners
Fixes issue with QuantumError.to_dict causing a huge performance regression in noisy simulations from its calling of `qiskit.assemble` inside Pybind11 code.
chriseclectic
force-pushed
the
fix-qerror-assemble
branch
from
ea41be2
to
595886a
Compare
chriseclectic
changed the title
jakelishman
reviewed
Dec 16, 2021
jakelishman
approved these changes
Dec 16, 2021
chriseclectic
added a commit
to chriseclectic/qiskit-aer
that referenced
this pull request
Dec 16, 2021
Fixes issue with QuantumError.to_dict causing a huge performance regression in noisy simulations from its calling of `qiskit.assemble` inside Pybind11 code, which resulted in unintended nested python multiprocessing processes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1407 #1398
Fixes issue with QuantumError.to_dict causing a huge performance regression in noisy simulations from its calling of
qiskit.assembleinside Pybind11 code.Details and comments
This also fixed an inefficiency in the C++ controller
executefunction where the qobj config was deserialized/parsed twice (which doubled the performance regression in #1407)