Run truncation after resolving parameters #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtreinish
reviewed
Jan 18, 2022
chriseclectic
added
Changelog: Bugfix
hhorii
force-pushed
the
resolve_parameters_before_truncation
branch
from
a23d976
to
26825df
Compare
jakelishman
reviewed
Jan 19, 2022
hhorii
force-pushed
the
resolve_parameters_before_truncation
branch
4 times, most recently
from
4246739
to
4846c44
Compare
jakelishman
reviewed
Jan 26, 2022
Since 0.9.0, Aer reduces qubits and their instructions if they do not affect measured qubits. On the other hand, parameterized QObj contains indices of instructions and their values. Previously these values are set to instructions of a circuit after running truncation, which may reduce some of instructions. Consequently, indices of parameterized QObj may address wrong instructions in a truncated cicuit. This fix changes the order of processing of truncation and parameterization: First, Aer resolves paramers, and then runs truncation.
hhorii
force-pushed
the
resolve_parameters_before_truncation
branch
from
4846c44
to
47f2765
Compare
jakelishman
approved these changes
Feb 2, 2022
jakelishman
changed the title
hhorii
added a commit
that referenced
this pull request
Feb 9, 2022
* run truncation after resolving parameters Since 0.9.0, Aer reduces qubits and their instructions if they do not affect measured qubits. On the other hand, parameterized QObj contains indices of instructions and their values. Previously these values are set to instructions of a circuit after running truncation, which may reduce some of instructions. Consequently, indices of parameterized QObj may address wrong instructions in a truncated cicuit. This fix changes the order of processing of truncation and parameterization: First, Aer resolves paramers, and then runs truncation. * Reword release note Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
hhorii
added a commit
to hhorii/qiskit-aer
that referenced
this pull request
Feb 9, 2022
* run truncation after resolving parameters Since 0.9.0, Aer reduces qubits and their instructions if they do not affect measured qubits. On the other hand, parameterized QObj contains indices of instructions and their values. Previously these values are set to instructions of a circuit after running truncation, which may reduce some of instructions. Consequently, indices of parameterized QObj may address wrong instructions in a truncated cicuit. This fix changes the order of processing of truncation and parameterization: First, Aer resolves paramers, and then runs truncation. * Reword release note Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #1427.
Details and comments
Perform truncation after resolving parameters.
This solution is not optimal but acceptable. Truncation for all sets of parameters results the same. Ideally, one truncation for all the sets of parameters.
However, truncation can change indices of instructions in parameter map and mapping instruction indices of before- and after-truncation needs codes.