Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.6 #1430

Merged
merged 11 commits into from
Feb 21, 2022
Merged

Drop support for Python 3.6 #1430

merged 11 commits into from
Feb 21, 2022

Conversation

mtreinish
Copy link
Member

Summary

Now that Qiskit Aer 0.10.0 has been released that Qiskit no longer
supports python 3.6 (in the lead up to adding support for python 3.10).
This commit officially drops the support for python 3.6 and makes python
3.7 required to install qiskit-aer. It also removes all the ci jobs
still using 3.6 both for testing and building wheels.

Details and comments

Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps updates to the available tox environments as well?

Now that Qiskit Aer 0.10.0 has been released that Qiskit no longer
supports python 3.6 (in the lead up to adding support for python 3.10).
This commit officially drops the support for python 3.6 and makes python
3.7 required to install qiskit-aer. It also removes all the ci jobs
still using 3.6 both for testing and building wheels.
@mtreinish
Copy link
Member Author

Perhaps updates to the available tox environments as well?

Done in the most recent revision.

jakelishman
jakelishman previously approved these changes Jan 18, 2022
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are all the references to Python 3.6 I could find too - looks good to me.

@jakelishman
Copy link
Member

Oh wait, we probably need an update release note still.

@mtreinish
Copy link
Member Author

Oh wait, we probably need an update release note still.

Added in: f1c65be

@mtreinish mtreinish added the Changelog: Removal Include in the Removed section of the changelog label Jan 18, 2022
Co-authored-by: Jake Lishman <jake@binhbar.com>
jakelishman
jakelishman previously approved these changes Jan 18, 2022
This commit removes all the environment variable usage for default
configuration of cibuildwheel and switches to use the pyproject.toml to
centralize the configuration for all the jobs. Environment variables are
still used for per job custom overrides which don't really fit in the
configuration of the pyproject.toml (mainly cross-build overrides and
GPU configuration).
Newer versions of cibuildwheel support building musllinux wheels for
musl libc based linux distros, such as alpine linux, in addition to
manylinux wheels (which are not compatible with musl libc based
linux distros and only work with glibc distros). The musllinux build
environments are different and not centos based so builds fail in them.
Since we're not supporting musl platforms in qiskit-aer we don't need to
attempt to build wheels for that platform. This commit adds musllinux
builds to the skip list in the common cibuildwheel configuration
accordingly.
jakelishman
jakelishman previously approved these changes Jan 19, 2022
@hhorii hhorii added this to the Aer 0.10.3 milestone Feb 2, 2022
@jakelishman
Copy link
Member

@hhorii: we can't drop support for a Python version in a patch release - this should wait for Aer 0.11.

@mtreinish mtreinish removed this from the Aer 0.10.3 milestone Feb 2, 2022
@hhorii hhorii added this to the Aer 0.11.0 milestone Feb 15, 2022
@jakelishman jakelishman merged commit 8c400ca into Qiskit:main Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Removal Include in the Removed section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants