-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Python 3.6 #1430
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps updates to the available tox environments as well?
Now that Qiskit Aer 0.10.0 has been released that Qiskit no longer supports python 3.6 (in the lead up to adding support for python 3.10). This commit officially drops the support for python 3.6 and makes python 3.7 required to install qiskit-aer. It also removes all the ci jobs still using 3.6 both for testing and building wheels.
Done in the most recent revision. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are all the references to Python 3.6 I could find too - looks good to me.
Oh wait, we probably need an update release note still. |
Added in: f1c65be |
Co-authored-by: Jake Lishman <jake@binhbar.com>
This commit removes all the environment variable usage for default configuration of cibuildwheel and switches to use the pyproject.toml to centralize the configuration for all the jobs. Environment variables are still used for per job custom overrides which don't really fit in the configuration of the pyproject.toml (mainly cross-build overrides and GPU configuration).
Newer versions of cibuildwheel support building musllinux wheels for musl libc based linux distros, such as alpine linux, in addition to manylinux wheels (which are not compatible with musl libc based linux distros and only work with glibc distros). The musllinux build environments are different and not centos based so builds fail in them. Since we're not supporting musl platforms in qiskit-aer we don't need to attempt to build wheels for that platform. This commit adds musllinux builds to the skip list in the common cibuildwheel configuration accordingly.
@hhorii: we can't drop support for a Python version in a patch release - this should wait for Aer 0.11. |
Summary
Now that Qiskit Aer 0.10.0 has been released that Qiskit no longer
supports python 3.6 (in the lead up to adding support for python 3.10).
This commit officially drops the support for python 3.6 and makes python
3.7 required to install qiskit-aer. It also removes all the ci jobs
still using 3.6 both for testing and building wheels.
Details and comments