Add support for BackendV2 in NoiseModel.from_backend #1484

itoko · 2022-03-16T07:50:00Z

Summary

Fixes #1477 by adding support for BackendV2 in NoiseModel.from_backend.

Details and comments

Updates basic_device_readout_errors and basic_device_gate_errors functions in noise.device.models module so that they can take a Target instead of a BackendProperties.

Not supporting standard_gates and warnings options for BackendV2 because those options are (planned to be) deprecated.

Requiring terra#7736 as a prerequisite.

mtreinish

Overall LGTM, some small inline comments. The only other thing is that we need to bump the minimum qiskit-terra version to 0.20.0 since some of the QubitProperties usage was only added in 0.20.0

mtreinish · 2022-06-14T13:44:32Z

qiskit/providers/aer/noise/device/models.py


 logger = logging.getLogger(__name__)


-def basic_device_readout_errors(properties):
+def basic_device_readout_errors(properties, target=None):


Should we make properties optional here too? Right now you'll have to call this like basic_device_readout_errors(None, target=target) to use this.

Good point. Done in 9a6ac73

qiskit/providers/aer/noise/device/models.py

mtreinish · 2022-06-14T13:49:07Z

qiskit/providers/aer/noise/device/models.py

@@ -84,18 +102,43 @@ def basic_device_gate_errors(properties,
        standard_gates (bool): DEPRECATED, If true return errors as standard
                               qobj gates. If false return as unitary
                               qobj instructions (Default: None).
-        warnings (bool): Display warnings (Default: True).
+        warnings (bool): PLAN TO BE DEPRECATED, Display warnings (Default: True).


We should raise a PendingDeprecationWarning if this is set. (Maybe change the default to None and condition the warning on it not being None.

Done in 30c3930

qiskit/providers/aer/noise/device/models.py

qiskit/providers/aer/noise/noise_model.py

mtreinish · 2022-06-14T13:58:46Z

qiskit/providers/aer/noise/noise_model.py

+                target = copy.deepcopy(target)
+                for op_name, qubits, value in gate_lengths:
+                    prop = target[op_name][qubits]
+                    prop.duration = value * _NANOSECOND_UNITS[gate_length_units]


Does _NANOSECOND_UNITS convert to ns or to seconds? The units for InstructionProperties.duration should be in seconds.

Good catch! Fixed at bad25ec

mtreinish · 2022-06-14T14:00:56Z

qiskit/providers/aer/noise/noise_model.py

+                    prop = target[op_name][qubits]
+                    prop.duration = value * _NANOSECOND_UNITS[gate_length_units]
+                    target.update_instruction_properties(op_name, qubits, prop)
+            all_qubit_properties = backend.target.qubit_properties


You can use the backend.qubit_properties() method as a backup here if needed since the qubit_properties target attribute only was added in 0.20.0, so it's possible that a BackendV2 instance from 0.19.x is missing the target implementation but has it on the backend. This pretty unlikely though so it's not required.

I've just bumped the minimum terra version to 0.20.0 in a46948b.

mtreinish · 2022-06-14T14:01:46Z

test/terra/noise/test_noise_model.py

+    def test_noise_model_from_backend_v2(self):
+        circ = QuantumCircuit(2)
+        circ.x(0)
+        circ.x(1)
+        circ.measure_all()
+
+        backend = mock.FakeBackendV2()
+        noise_model = NoiseModel.from_backend(backend)
+        circ = transpile(circ, backend, optimization_level=0)
+        result = AerSimulator().run(circ, noise_model=noise_model).result()
+        self.assertTrue(result.success)


Do you want to add some tests that use fake devices from terra like FakeLagosV2 or something?

Good suggestion. I added it in 192a7ab and found a bug, so fixed in 5e88501

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

itoko · 2022-06-17T08:22:15Z

@mtreinish Thank you for your review. I've updated the code accordingly. Could you take a second look?

mtreinish

Thanks for making the updates so quickly. Just an inline question and a suggested improvement to the warning message. Otherwise I think this is good to go.

mtreinish · 2022-06-24T18:28:55Z

qiskit/providers/aer/noise/device/models.py

+    else:
+        # create from Target
+        for q in range(target.num_qubits):
+            prop = target['measure'][(q,)]


I'm not sure we want to do this with a get item here without checking that measure is defined in the target. I think in practical terms almost every target will have this defined but it's not guaranteed.

qiskit/providers/aer/noise/device/models.py

qiskit/providers/aer/noise/noise_model.py

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

itoko · 2022-06-28T00:48:45Z

@mtreinish I've got an error during tox -edocs. It seems to come from warnings, treated as error by "-W" option in the sphinx-build command. How do you think we should fix this error?

mtreinish · 2022-06-28T00:51:42Z

It's caused by the recent sphinx release, #1548 should have fixed it

mtreinish

LGTM, sorry for the slow review. Thanks for updating things

Add support for BackendV2 in NoiseModel.from_backend

6294344

itoko force-pushed the fix-1477-backendv2 branch from 72b9651 to 6294344 Compare April 21, 2022 01:21

Fix lint and doc

a198212

itoko force-pushed the fix-1477-backendv2 branch from 395c5eb to a198212 Compare April 21, 2022 01:49

itoko marked this pull request as ready for review April 22, 2022 00:39

itoko changed the title ~~[WIP] Add support for BackendV2 in NoiseModel.from_backend~~ Add support for BackendV2 in NoiseModel.from_backend Apr 22, 2022

hhorii requested a review from mtreinish April 26, 2022 06:43

hhorii added 4 commits April 26, 2022 15:44

Merge branch 'main' into fix-1477-backendv2

ebade4d

Merge branch 'main' into fix-1477-backendv2

445e3ef

Merge branch 'main' into fix-1477-backendv2

b620713

Merge branch 'main' into fix-1477-backendv2

63b11e4

mtreinish reviewed Jun 14, 2022

View reviewed changes

itoko and others added 9 commits June 17, 2022 10:07

Apply suggestions from code review

cfc2e8a

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

Raise pending deprecation warnings

30c3930

Fix a bug in unit conversion

bad25ec

Bump the minimum qiskit-terra version to 0.20.0

a46948b

Make properties optional

9a6ac73

Fix filterwarnings

3b04347

Add test with FakeLagosV2

192a7ab

Fix a bug in the case inst prop is None

5e88501

Add reno

e824065

Merge branch 'main' into fix-1477-backendv2

d833f07

mtreinish reviewed Jun 24, 2022

View reviewed changes

itoko and others added 3 commits June 27, 2022 10:07

Apply suggestions from code review

c7b9d40

Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

Take care the case of no prop dict for measure

d4714b2

Merge branch 'main' into fix-1477-backendv2

011cd01

Merge branch 'main' into fix-1477-backendv2

ef426d1

hhorii and others added 3 commits June 28, 2022 22:49

Merge branch 'main' into fix-1477-backendv2

27dfa07

Merge branch 'main' into fix-1477-backendv2

6bd9b5f

Replace test.mock with providers.fake_provider

1d3f190

itoko requested a review from mtreinish July 11, 2022 00:30

mtreinish approved these changes Jul 12, 2022

View reviewed changes

mtreinish added Changelog: New Feature Include in the Added section of the changelog automerge This PR will automatically merge once its CI has passed labels Jul 12, 2022

mergify bot merged commit c53acd3 into Qiskit:main Jul 12, 2022

HuangJunye mentioned this pull request Jul 12, 2022

Update FakeBackendV2.run method after Aer adds support for BackendV2 Qiskit/qiskit#7829

Open

itoko mentioned this pull request Nov 29, 2022

Noise model created from BackendV2 contains excessive noises on measures. #1648

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for BackendV2 in NoiseModel.from_backend #1484

Add support for BackendV2 in NoiseModel.from_backend #1484

itoko commented Mar 16, 2022 •

edited

Loading

mtreinish left a comment

mtreinish Jun 14, 2022

itoko Jun 17, 2022

mtreinish Jun 14, 2022

itoko Jun 17, 2022

mtreinish Jun 14, 2022

itoko Jun 17, 2022

mtreinish Jun 14, 2022

itoko Jun 17, 2022

mtreinish Jun 14, 2022

itoko Jun 17, 2022

itoko commented Jun 17, 2022

mtreinish left a comment

mtreinish Jun 24, 2022

itoko commented Jun 28, 2022

mtreinish commented Jun 28, 2022

mtreinish left a comment

Add support for BackendV2 in NoiseModel.from_backend #1484

Add support for BackendV2 in NoiseModel.from_backend #1484

Conversation

itoko commented Mar 16, 2022 • edited Loading

Summary

Details and comments

mtreinish left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

itoko commented Jun 17, 2022

mtreinish left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

itoko commented Jun 28, 2022

mtreinish commented Jun 28, 2022

mtreinish left a comment

Choose a reason for hiding this comment

itoko commented Mar 16, 2022 •

edited

Loading