Remove deprecated functions in noise module #1624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@itoko Can you add a release note for removing and adding deprecation? |
|
Qiskit/qiskit-tutorials#1397 should resolve the CI failure. |
|
One more blocking fix: Qiskit/qiskit#9542 |
mtreinish
reviewed
Feb 7, 2023
Comment on lines
12
to
24
| - | | ||
| A deprecated ``standard_gates`` argument broadly used in several methods and functions | ||
| across :mod:`~.noise` module has been removed. | ||
| - | | ||
| The constructor of :class:`QuantumError` has now dropped deprecated arguments, | ||
| ``number_of_qubits``, ``standard_gates`` and ``atol``, and the support of deprecated | ||
| json-like objects for ``noise_ops`` argument. | ||
| - | | ||
| The deprecated :mod:`utils.noise_remapper` and :mod:`noise.errors.errorutils` modules | ||
| have been entirely removed. | ||
| - | | ||
| All deprecated functions and classes | ||
| in :mod:`utils.noise_transformation` module has been removed. |
There was a problem hiding this comment.
For these release notes are there any alternatives available? It'd be good to document what existing users should do instead or why they're not longer supported. Also listing the specifics can be helpful, just being a bit more explicit about what was removed.
Comment on lines
+1096
to
+1145
| def _standard_gate_unitary(name): | ||
| # To be removed with from_dict | ||
| unitary_matrices = { | ||
| ("id", "I"): | ||
| np.eye(2, dtype=complex), | ||
| ("x", "X"): | ||
| np.array([[0, 1], [1, 0]], dtype=complex), | ||
| ("y", "Y"): | ||
| np.array([[0, -1j], [1j, 0]], dtype=complex), | ||
| ("z", "Z"): | ||
| np.array([[1, 0], [0, -1]], dtype=complex), | ||
| ("h", "H"): | ||
| np.array([[1, 1], [1, -1]], dtype=complex) / np.sqrt(2), | ||
| ("s", "S"): | ||
| np.array([[1, 0], [0, 1j]], dtype=complex), | ||
| ("sdg", "Sdg"): | ||
| np.array([[1, 0], [0, -1j]], dtype=complex), | ||
| ("t", "T"): | ||
| np.array([[1, 0], [0, np.exp(1j * np.pi / 4)]], dtype=complex), | ||
| ("tdg", "Tdg"): | ||
| np.array([[1, 0], [0, np.exp(-1j * np.pi / 4)]], dtype=complex), | ||
| ("cx", "CX", "cx_01"): | ||
| np.array([[1, 0, 0, 0], [0, 0, 0, 1], [0, 0, 1, 0], [0, 1, 0, 0]], dtype=complex), | ||
| ("cx_10",): | ||
| np.array([[1, 0, 0, 0], [0, 0, 0, 1], [0, 0, 1, 0], [0, 1, 0, 0]], dtype=complex), | ||
| ("cz", "CZ"): | ||
| np.array([[1, 0, 0, 0], [0, 1, 0, 0], [0, 0, 1, 0], [0, 0, 0, -1]], dtype=complex), | ||
| ("swap", "SWAP"): | ||
| np.array([[1, 0, 0, 0], [0, 0, 1, 0], [0, 1, 0, 0], [0, 0, 0, 1]], dtype=complex), | ||
| ("ccx", "CCX", "ccx_012", "ccx_102"): | ||
| np.array([[1, 0, 0, 0, 0, 0, 0, 0], [0, 1, 0, 0, 0, 0, 0, 0], | ||
| [0, 0, 1, 0, 0, 0, 0, 0], [0, 0, 0, 0, 0, 0, 0, 1], | ||
| [0, 0, 0, 0, 1, 0, 0, 0], [0, 0, 0, 0, 0, 1, 0, 0], | ||
| [0, 0, 0, 0, 0, 0, 1, 0], [0, 0, 0, 1, 0, 0, 0, 0]], | ||
| dtype=complex), | ||
| ("ccx_021", "ccx_201"): | ||
| np.array([[1, 0, 0, 0, 0, 0, 0, 0], [0, 1, 0, 0, 0, 0, 0, 0], | ||
| [0, 0, 1, 0, 0, 0, 0, 0], [0, 0, 0, 1, 0, 0, 0, 0], | ||
| [0, 0, 0, 0, 1, 0, 0, 0], [0, 0, 0, 0, 0, 0, 0, 1], | ||
| [0, 0, 0, 0, 0, 0, 1, 0], [0, 0, 0, 0, 0, 1, 0, 0]], | ||
| dtype=complex), | ||
| ("ccx_120", "ccx_210"): | ||
| np.array([[1, 0, 0, 0, 0, 0, 0, 0], [0, 1, 0, 0, 0, 0, 0, 0], | ||
| [0, 0, 1, 0, 0, 0, 0, 0], [0, 0, 0, 1, 0, 0, 0, 0], | ||
| [0, 0, 0, 0, 1, 0, 0, 0], [0, 0, 0, 0, 0, 1, 0, 0], | ||
| [0, 0, 0, 0, 0, 0, 0, 1], [0, 0, 0, 0, 0, 0, 1, 0]], | ||
| dtype=complex) | ||
| } | ||
|
|
||
| return next((value for key, value in unitary_matrices.items() if name in key), None) |
There was a problem hiding this comment.
Would it be more efficient to build this off of https://github.com/Qiskit/qiskit-terra/blob/main/qiskit/circuit/library/standard_gates/__init__.py#L108 since most of these can be built from the standard gate objects' .to_matrix() methods. But this is also a much smaller set and contains things outside the standard gate library too. So this is not critical, I was just surprised to see this.
hhorii
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove deprecated functions in noise module, e.g.
NoiseModel.add_nonlocal_quantum_error, support of json-like input forQuantumErrorandstandard_gatesargument in manystandard_errors.Note that
NoiseModel.from_dictis NOT removed exceptionally until alternative methods for serialize/deserializeNoiseModelobjects are provided.Details and comments
noise.errors.errorutilsandutils.noise_remapperNoiseModelandQuantumErrorstandard_gatesinnoise.errors.standard_errorswarningsargument inNoiseModel(updated from PendingDeprecationWarning)The following PRs must be merged before this PR.