Fix device noise model from BackendV2 not to have excessive quantum errors on measures/resets #1649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itoko
added
stable-backport-potential
itoko
force-pushed
the
fix-device-noise-from-target
branch
from
f8378c1
to
bda43f9
Compare
|
I might need to rethink relaxation errors on resets (on hold until how to fix the spec).
|
chriseclectic
approved these changes
Nov 29, 2022
itoko
added
the
automerge
hhorii
pushed a commit
to hhorii/qiskit-aer
that referenced
this pull request
Dec 1, 2022
…rrors on measures/resets (Qiskit#1649) * Fix devide noise model from target * Add release note * Upgrade device noise models not to have errors on resets * Revert the previous upgrade and fix the bug so that the behevior is the same as for backend v1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1648 by updating device noise models not to have excessive quantum errors on non-gate instructions such as measures and resets when creating them from BackendV2.
Details and comments
This commit fixes
qiskit_aer.noise.device.models.basic_device_gate_errorsnot to generateQuantumErrors (neither depolarizing nor relaxation) forMeasureinstruction and not to generate depolarizing errors for other non-Gate instructions whenTargetobject is supplied.