Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix required_memory_mb #1881

Merged
merged 3 commits into from
Jul 27, 2023
Merged

Fix required_memory_mb #1881

merged 3 commits into from
Jul 27, 2023

Conversation

doichanj
Copy link
Collaborator

Summary

This is fix for issue #1878

Details and comments

requried_memory_mb function for statevector returns wrong value when number of qubits is very large because of overflow of 64 bits integer.
Now it returns SIZE_MAX value when number of qubits is too large so that Qiskit Aer can know memory is not sufficient for statvector/unitary/density matrix methods.

@doichanj doichanj requested a review from hhorii July 26, 2023 06:52
@hhorii hhorii added the stable-backport-potential The issue or PR might be minimal and/or import enough to backport to stable label Jul 27, 2023
Copy link
Collaborator

@hhorii hhorii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hhorii hhorii added the automerge This PR will automatically merge once its CI has passed label Jul 27, 2023
@mergify mergify bot merged commit 77a101b into Qiskit:main Jul 27, 2023
32 checks passed
doichanj added a commit to doichanj/qiskit-aer that referenced this pull request Aug 9, 2023
* Fix required_memory_mb

* add release note

---------

Co-authored-by: Hiroshi Horii <hhorii@users.noreply.github.com>
hhorii added a commit to hhorii/qiskit-aer that referenced this pull request Aug 9, 2023
* Fix required_memory_mb

* add release note

---------

Co-authored-by: Hiroshi Horii <hhorii@users.noreply.github.com>
hhorii added a commit that referenced this pull request Aug 9, 2023
* adding executor classes for parallel simulations

* fix merge conflicts

* simplify sub-classes

* fix unformatted code

* fix unformatted code again

* Fix MPI code

* Fix shot-branching was not enabled with noise sampling

* Fix clang format

* set_num_qubits to virtual function to set correct num qubits on matrix

* reflecting review comments

* reuse of random number generator

* recover save_data_per_shot

* add missed omp threads setting in statevector, change class hieralchy

* Fix performance issue of GPU shot-branching

* move fusion outside of loop for non noise dynamic circuits

* fix shot-branching options in aer_compiler.py

* save codes before merge

* Fix format

* Fix multi-chunk with cuStateVec

* format

* format

* add better multi-GPU distribution for shot-branching

* fix format

* Changed option shot_branching_enable=False by default, add shot_branching_sampling_enable (False by default), add test cases for shot-branching

* format

* format test_shot_branching.py

* Changed OpenMP threading for shot-branching

* mutable to matrix and param buffer

* format

* add target_gpus option

* Remove Python 3.7 from Github actions (#1819)

Since 0.13.0, Aer does not support Python 3.7.
This commit removes github actions for CI.

* Removing python 3.7 from test workflow
* Removing python 3.7 from build workflow
* Removing python 3.7 from deploy workflow
* Removing python 3.7 from tox
* revert
* Remove python 3.7 from pyproject.toml
* Remove python 3.7 from pyproject.toml - tool
---------

Co-authored-by: Hiroshi Horii <hhorii@users.noreply.github.com>

* Fix missing dynamic link path for CUDA runtime and cuQuantum libraries (#1877)

Co-authored-by: Hiroshi Horii <hhorii@users.noreply.github.com>

* Fix OpenMP nested parallel (#1880)

* Fix OpenMP nested parallel

* add comment in release note

* fix true and false

* fix format

---------

Co-authored-by: Hiroshi Horii <hhorii@users.noreply.github.com>

* Support u3 gate application in Aer runtime API (#1876)

* Support u3 gate application

* Apply clang-format

* Revert clang-format for aer_runtime_api.h

* Add release note

---------

Co-authored-by: Hiroshi Horii <hhorii@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

* Fix required_memory_mb (#1881)

* Fix required_memory_mb

* add release note

---------

Co-authored-by: Hiroshi Horii <hhorii@users.noreply.github.com>

* format

* format

* format

* comment out target_gpu setting for non-GPU

* comment out target_gpu setting for non-GPU

* Remove `PulseSimulator` (#1884)

Since 0.12, Qiskit-Aer notices deprecation warnings to use of PulseSimulato. Because 0.13 will be released after +3 months since 0.12 was released, Qiskit-Aer will stop supports of pulse simulation.

* first pass at removing pulse simulator
* autoformat with black
* remove ref to aer pulse in docs
* fix lint issues
* remove pulse rst
* remove pulse tests
* add release note
* remove open pulse from CMakeLists.txt
* remove pulse tests
* remove remaining pulse codes

---------

Co-authored-by: AngeloDanducci <angelo.danducci.ii@ibm.com>

* Fix an issue in `aer_state_initialize()` of C API (#1885)

Correct C API `aer_state_initialize` to take an argument of `handler`.

* update aer_state_initialize API
* add reno

* fix MPI shot-branching sampling

* fix unmerged file

* remove conflict

* rerun tests

* recover files

* remove conflict

* fix non-gpu

* update release note

---------

Co-authored-by: Tung Bui (Leo) <85242618+tungbq@users.noreply.github.com>
Co-authored-by: Hiroshi Horii <hhorii@users.noreply.github.com>
Co-authored-by: Ryo Wakizaka <135729070+ibm-wakizaka@users.noreply.github.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: AngeloDanducci <angelo.danducci.ii@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge This PR will automatically merge once its CI has passed stable-backport-potential The issue or PR might be minimal and/or import enough to backport to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants