Make vector allocation aligned to 64-bytes #1909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ment requirement used by State data.
doichanj
added
stable-backport-potential
doichanj
approved these changes
Aug 24, 2023
doichanj
requested changes
Aug 25, 2023
|
Added release note for the fix. |
|
@doichanj , can you help understand how this PR is breaking the Windows builds? It shouldn't change anything there. I only see the compiler running out of memory. |
|
Windows build sometimes fails because of heap memory shortage. Only we can do is to rerun until it will not fail |
doichanj
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make vector allocation aligned to 64-bytes as that is the same alignment requirement used by QubitVector data.
Details and comments
AER::Vectoris in some cases used to initializeQubitVectordata and the code assumes that that storage is at least 32-byte aligned so that mm256 instructions can be used. This PR makesAER::Vectorstorage have the same alignment requirements (64-byte) asQubitVectorso that one doesn't get into segfaults when trying to access this storage with vector intrinsics.This fixes #1908.