Remove usage of qiskit.extensions
#2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The module has been pending deprecation since Qiskit 0.45. It is deprecated for 0.46 and removed in 1.0. This removal concerns the import location of ``UnitaryGate`` and the usage of the ``ExtensionError``. The first is easily fixed, whereas for the latter I tried using ``ValueError`` or ``TypeError``, which seemed to cover the error meanings. Technically, this is a breaking change and we could introduce an intermediary class that inherits from the deprecated ``ExtensionError`` and the new choice of error. However, since we will soon be changing to 1.0 and we also skipped this in Qiskit Terra (as we thought it highly unlikely that users are actually relying on this error type) it might be fine to just change the error type.
jakelishman
reviewed
Jan 8, 2024
There was a problem hiding this comment.
Changing the error types is technically not stable - what did we do for any ExtensionErrors being raised by the same objects during the move on the Terra side? If we can switch these over to match whatever we did there, that's probably the safest. If not, maybe let's make it QiskitError, since the chances are that if there's anybody attempting to catch these errors, that's what they'll be using.
|
Yeah that's what I tried to explain above; we didn't do anything and just changed the type: Qiskit/qiskit#10725 (comment). I can add an intermediary type, though that'll require a bunch of filtering warnings for the 0.46 release and is not compatible with Qiskit/qiskit#11488 since there we remove |
|
Oh sorry, the GitHub notification just took me to the diff and I missed that I hadn't already read the top comment of this one. Yeah, in that case let's just bite the bullet and accept it here too - if we did it on Terra, it'd be tricky to hold Aer to a higher standard. |
jakelishman
approved these changes
Jan 8, 2024
|
(I'll leave unmerged for the Aer team to look.) |
Cryoris
added a commit
to Cryoris/qiskit-terra
that referenced
this pull request
Jan 9, 2024
Merged
doichanj
pushed a commit
to doichanj/qiskit-aer
that referenced
this pull request
Jan 16, 2024
The module has been pending deprecation since Qiskit 0.45. It is deprecated for 0.46 and removed in 1.0. This removal concerns the import location of ``UnitaryGate`` and the usage of the ``ExtensionError``. The first is easily fixed, whereas for the latter I tried using ``ValueError`` or ``TypeError``, which seemed to cover the error meanings. Technically, this is a breaking change and we could introduce an intermediary class that inherits from the deprecated ``ExtensionError`` and the new choice of error. However, since we will soon be changing to 1.0 and we also skipped this in Qiskit Terra (as we thought it highly unlikely that users are actually relying on this error type) it might be fine to just change the error type.
doichanj
added a commit
that referenced
this pull request
Jan 17, 2024
* PR to release 0.13.2 * Remove usage of ``qiskit.extensions`` (#2023) The module has been pending deprecation since Qiskit 0.45. It is deprecated for 0.46 and removed in 1.0. This removal concerns the import location of ``UnitaryGate`` and the usage of the ``ExtensionError``. The first is easily fixed, whereas for the latter I tried using ``ValueError`` or ``TypeError``, which seemed to cover the error meanings. Technically, this is a breaking change and we could introduce an intermediary class that inherits from the deprecated ``ExtensionError`` and the new choice of error. However, since we will soon be changing to 1.0 and we also skipped this in Qiskit Terra (as we thought it highly unlikely that users are actually relying on this error type) it might be fine to just change the error type. * Fix GPU batched execution (#2014) * Fix GPU batched execution * format * Use Apple-specific API to determine system memory on macOS (#2016) The unistd.h API that had been used for both Linux and macOS is not always available in macOS environments, for example when building with upstream clang rather than AppleClang. Closes #1923 * Remove qiskit.test from test/common.py (#1971) * remove qiskit.test from test/common.py * fix format, add releasenote --------- Co-authored-by: Hiroshi Horii <hhorii@users.noreply.github.com> * raise Qiskit dependency to 0.45.0 (#2008) Co-authored-by: Hiroshi Horii <hhorii@users.noreply.github.com> * `deprecate_func(..., since=...)` should be a string, not a float (#2006) * deprecate_func "since" parameter should be a str, not a float * black * Avoid accessing GPUs when using CPU only (#2012) * avoid accessing GPUs when using CPU only * remove unused import/parameter * Reduce warning meesages (#2013) * reduce warning meesages * format * fix Windows * uint -> uint_t * fix Thrust seg fault * format * Add support for running with Python 3.12 (#2022) * Add support for running with Python 3.12 Python 3.12.0 was released on 10-02-2023, this commit marks the start of support for Python 3.12 in qiskit-aer. It adds the supported Python version in the package metadata and updates the CI configuration to run test jobs on Python 3.12 and build Python 3.12 wheels on release. * Remove numpy constraints * Uncap six * Fix i686 build steps * Use python 3.12.0 in tests to work around unittest breakage in 3.12.1 * Use 3.12.0 for all test jobs --------- Co-authored-by: Jun Doi <doichan@jp.ibm.com> * enable bit operations for boolean types (#2024) Co-authored-by: Jun Doi <doichan@jp.ibm.com> --------- Co-authored-by: Julien Gacon <gaconju@gmail.com> Co-authored-by: Will Shanks <willshanks@us.ibm.com> Co-authored-by: Hiroshi Horii <hhorii@users.noreply.github.com> Co-authored-by: Luciano Bello <bel@zurich.ibm.com> Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Cryoris
added a commit
to Cryoris/qiskit-terra
that referenced
this pull request
Jan 17, 2024
This reverts commit 5dbe66d.
github-merge-queue bot
pushed a commit
to Qiskit/qiskit
that referenced
this pull request
Jan 17, 2024
* Delete ``qiskit-extensions`` for 1.0 * add reno * black * rm deprecate qc methods + extensions mod * Update reno, remove dangling TeX file * Lint and latex test * Try fix docstring, detailed reno * Update plot barrier test Snapshot instruction has been removed * Skip Aer tests that rely on Qiskit/qiskit-aer#2023 * Fix barrier image * Revert "Skip Aer tests that rely on Qiskit/qiskit-aer#2023" This reverts commit 5dbe66d.
github-merge-queue bot
pushed a commit
to Qiskit/qiskit
that referenced
this pull request
Jan 17, 2024
* Delete ``qiskit-extensions`` for 1.0 * add reno * black * rm deprecate qc methods + extensions mod * Update reno, remove dangling TeX file * Lint and latex test * Try fix docstring, detailed reno * Update plot barrier test Snapshot instruction has been removed * Skip Aer tests that rely on Qiskit/qiskit-aer#2023 * Fix barrier image * Revert "Skip Aer tests that rely on Qiskit/qiskit-aer#2023" This reverts commit 5dbe66d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
qiskit.extensionsmodule has been pending deprecation since Qiskit 0.45. It is deprecated for 0.46 and removed in 1.0.This is blocking Qiskit/qiskit#11488 and Qiskit/qiskit#11498.
Details and comments
This removal concerns the import location of
UnitaryGateand the usage of theExtensionError. The first is easily fixed, whereas for the latter I tried usingValueErrororTypeError, which seemed to cover the error meanings. Technically, this is a breaking change and we could introduce an intermediary class that inherits from the deprecatedExtensionErrorand the new choice of error. However, since we will soon be changing to 1.0 and we also skipped this in Qiskit Terra (as we thought it highly unlikely that users are actually relying on this error type) it might be fine to just change the error type.