-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove remaining diagonal, isometry and uc #2040
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doichanj
added
stable-backport-potential
The issue or PR might be minimal and/or import enough to backport to stable
Changelog: Deprecation
Include in Deprecated section of changelog
labels
Jan 26, 2024
hhorii
previously approved these changes
Jan 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a minor comment. It is not mandatory for merge.
from ddt import ddt | ||
from test.terra.reference import ref_conditionals | ||
from test.terra.backends.simulator_test_case import SimulatorTestCase, supported_methods | ||
|
||
from qiskit import QuantumCircuit | ||
from qiskit import transpile, QuantumCircuit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
transpile
is not used.
hhorii
added
the
Changelog: None
PRs that don't have an associated changelog entry.
label
Jan 29, 2024
doichanj
changed the title
Remove remaining diagonal
Remove remaining diagonal, isometry and uc
Jan 29, 2024
hhorii
approved these changes
Jan 29, 2024
doichanj
added a commit
to doichanj/qiskit-aer
that referenced
this pull request
Feb 6, 2024
* Remove remaining diagonal * remove unused import transpile, replace isometry, uc to Isometry, UCGate * format
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Changelog: Deprecation
Include in Deprecated section of changelog
Changelog: None
PRs that don't have an associated changelog entry.
stable-backport-potential
The issue or PR might be minimal and/or import enough to backport to stable
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removed remaining diagonal, isometry and uc that causes test failure with the latest Qiskit
Details and comments
Removed
circuit.diagonal
used in test cases and replaced tocircuit.append(DiagonalGate(), [])
Replacing isometry and uc as well