Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining diagonal, isometry and uc #2040

Merged
merged 3 commits into from
Jan 29, 2024

Conversation

doichanj
Copy link
Collaborator

@doichanj doichanj commented Jan 26, 2024

Summary

This PR removed remaining diagonal, isometry and uc that causes test failure with the latest Qiskit

Details and comments

Removed circuit.diagonal used in test cases and replaced to circuit.append(DiagonalGate(), [])
Replacing isometry and uc as well

@doichanj doichanj added stable-backport-potential The issue or PR might be minimal and/or import enough to backport to stable Changelog: Deprecation Include in Deprecated section of changelog labels Jan 26, 2024
hhorii
hhorii previously approved these changes Jan 29, 2024
Copy link
Collaborator

@hhorii hhorii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a minor comment. It is not mandatory for merge.

from ddt import ddt
from test.terra.reference import ref_conditionals
from test.terra.backends.simulator_test_case import SimulatorTestCase, supported_methods

from qiskit import QuantumCircuit
from qiskit import transpile, QuantumCircuit
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

transpile is not used.

@hhorii hhorii added the Changelog: None PRs that don't have an associated changelog entry. label Jan 29, 2024
@doichanj doichanj changed the title Remove remaining diagonal Remove remaining diagonal, isometry and uc Jan 29, 2024
@doichanj doichanj requested a review from hhorii January 29, 2024 06:55
@hhorii hhorii merged commit 6f375e3 into Qiskit:main Jan 29, 2024
35 checks passed
doichanj added a commit to doichanj/qiskit-aer that referenced this pull request Feb 6, 2024
* Remove remaining diagonal

* remove unused import transpile, replace isometry, uc to Isometry, UCGate

* format
@doichanj doichanj mentioned this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Deprecation Include in Deprecated section of changelog Changelog: None PRs that don't have an associated changelog entry. stable-backport-potential The issue or PR might be minimal and/or import enough to backport to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants