Add private primitive attributes removed by qiskit

[ihincks]

Summary

Qiskit/qiskit#11051 removed some private attributes from Sampler and Estimator in the process of streamlining the API. This PR adds them back in because super() no longer does so.

Details and comments

[jakelishman]

Using Qiskit 1.0.0rc1, this gets me further through the Aer test suite, but then all the primitives tests fail with an error like this:

{6} test.terra.primitives.test_sampler.TestSampler.test_multiple_cregs [0.011242s] ... FAILED

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    Traceback (most recent call last):

      File "/Users/jake/code/qiskit/aer/test/terra/primitives/test_sampler.py", line 270, in test_multiple_cregs
    result = Sampler().run(qc, shots=100).result()

      File "/Users/jake/code/qiskit/terra/qiskit/primitives/base/base_sampler.py", line 200, in run
    return self._run(

      File "/Users/jake/code/qiskit/aer/qiskit_aer/primitives/sampler.py", line 165, in _run
    job.submit()

    AttributeError: 'PrimitiveJob' object has no attribute 'submit'

[1ucian0]

PrimitiveJob.submit was remove in Qiskit/qiskit#11552

[jakelishman]

Also there's two tests that do this, but I think that's it for the differences:

test.terra.primitives.test_estimator.TestEstimator.test_init_observable_from_operator_1_True
--------------------------------------------------------------------------------------------

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    Traceback (most recent call last):

      File "/Users/jake/code/qiskit/venv310/lib/python3.10/site-packages/ddt.py", line 225, in wrapper
    return func(self, *args, **kwargs)

      File "/Users/jake/code/qiskit/aer/test/terra/primitives/test_estimator.py", line 100, in test_init_observable_from_operator
    result = est.run([circuit], [matrix], seed=15, shots=8192).result()

      File "/Users/jake/code/qiskit/terra/qiskit/primitives/base/base_estimator.py", line 246, in run
    circuits, observables, parameter_values = validation._validate_estimator_args(

      File "/Users/jake/code/qiskit/terra/qiskit/primitives/base/validation.py", line 56, in _validate_estimator_args
    observables = _validate_observables(observables)

      File "/Users/jake/code/qiskit/terra/qiskit/primitives/base/validation.py", line 175, in _validate_observables
    return tuple(init_observable(obs) for obs in observables)

      File "/Users/jake/code/qiskit/terra/qiskit/primitives/base/validation.py", line 175, in <genexpr>
    return tuple(init_observable(obs) for obs in observables)

      File "/Users/jake/code/qiskit/terra/qiskit/primitives/utils.py", line 64, in init_observable
    raise QiskitError(f"observable type not supported: {type(observable)}")

    qiskit.exceptions.QiskitError: "observable type not supported: <class 'qiskit.quantum_info.operators.operator.Operator'>"


test.terra.primitives.test_estimator.TestEstimator.test_init_observable_from_operator_2_False
---------------------------------------------------------------------------------------------

Captured traceback:
~~~~~~~~~~~~~~~~~~~
    Traceback (most recent call last):

      File "/Users/jake/code/qiskit/venv310/lib/python3.10/site-packages/ddt.py", line 225, in wrapper
    return func(self, *args, **kwargs)

      File "/Users/jake/code/qiskit/aer/test/terra/primitives/test_estimator.py", line 100, in test_init_observable_from_operator
    result = est.run([circuit], [matrix], seed=15, shots=8192).result()

      File "/Users/jake/code/qiskit/terra/qiskit/primitives/base/base_estimator.py", line 246, in run
    circuits, observables, parameter_values = validation._validate_estimator_args(

      File "/Users/jake/code/qiskit/terra/qiskit/primitives/base/validation.py", line 56, in _validate_estimator_args
    observables = _validate_observables(observables)

      File "/Users/jake/code/qiskit/terra/qiskit/primitives/base/validation.py", line 175, in _validate_observables
    return tuple(init_observable(obs) for obs in observables)

      File "/Users/jake/code/qiskit/terra/qiskit/primitives/base/validation.py", line 175, in <genexpr>
    return tuple(init_observable(obs) for obs in observables)

      File "/Users/jake/code/qiskit/terra/qiskit/primitives/utils.py", line 64, in init_observable
    raise QiskitError(f"observable type not supported: {type(observable)}")

    qiskit.exceptions.QiskitError: "observable type not supported: <class 'qiskit.quantum_info.operators.operator.Operator'>"

[ihincks]

all the primitives tests fail with an error like this

submit() was removed as a public method on our base job class, so the most direct solution is to call _submit().

[jakelishman]

As of 71f4ca8, with the merge of #2047, this passes the test suite on 1.0.0rc1 except for the two things about Operator in my previous comment, but lint appears to be saying that PrimitiveJob._submit didn't exist in 0.45/0.46, so we need a fix such that Aer works with both.

[ihincks]

Thanks, I'm doing the wrong thing and trying to get away without setting up my test env locally, as I've never worked on aer.

[jakelishman]

Yeah no worries, I suspected that might be the case, and I have an environment to hand here already.

[jakelishman]

This passes the test suite locally for me for Qiskits 0.45.3, 0.46.0 and 1.0.0rc1. Thanks Ian!

This should be reviewed by a member of the primitives team before more.