Only run sdist build after wheel builds are uploaded #2054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the configuration of the deploy workflow to install the sdist last. Publishing the sdist first causes disruption for downstream projects that are using qiskit aer in CI as pip will eagerly try to download the latest version even if only an sdist is present for it. To avoid disruption for downstream users this updates the sdist job to run only after we've uploaded the wheels for the tier 1 platforms to pypi (which is what most people are running in CI).
jakelishman
approved these changes
Feb 6, 2024
jakelishman
added
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit changes the configuration of the deploy workflow to install the sdist last. Publishing the sdist first causes disruption for downstream projects that are using qiskit aer in CI as pip will eagerly try to download the latest version even if only an sdist is present for it. To avoid disruption for downstream users this updates the sdist job to run only after we've uploaded the wheels for the tier 1 platforms to pypi (which is what most people are running in CI).
Details and comments