Implementing SamplerV2 #2090
Merged
Implementing SamplerV2 #2090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doichanj
added
the
Changelog: New Feature
hhorii
previously approved these changes
Mar 29, 2024
Merged
hhorii
previously approved these changes
Mar 29, 2024
ikkoham
reviewed
Mar 30, 2024
qiskit_aer/primitives/sampler_v2.py
Outdated
| def __init__( | ||
| self, | ||
| *, | ||
| backend: AerSimulator = None, |
There was a problem hiding this comment.
Could you consider the options class and backend_options adopted by estimator for consistency. I am not sure which is better. Perhaps the Estimator side should be changed to match this specification.
There was a problem hiding this comment.
Note that this option class comes from BackendSampler/Estimator.
hhorii
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds implementation of SamplerV2 in
qiskit_aer.primitives#2078Details and comments
This is based on
qiskit.primitives.StatevectorSamplerI think we need further optimization for simulator in the next release.