Add support for ECR gate to MPS #2137

doichanj · 2024-05-13T06:54:46Z

Summary

Details and comments

Add native support of ECR gate in MPS and extended_stabilizer methods
(Also added for tensor_network method that was supported but not in basis_gates)
Add check of basis_gates passed to backend options if there is unsupported gate for the method
Fix test case for ECR gate

enum-class · 2024-05-23T03:51:31Z

src/simulators/extended_stabilizer/gates.hpp

@@ -85,6 +86,7 @@ const AER::stringmap_t<Gatetypes> gate_types_ = {
    {"cx", Gatetypes::clifford},   // Controlled-X gate (CNOT)
    {"cz", Gatetypes::clifford},   // Controlled-Z gate
    {"swap", Gatetypes::clifford}, // SWAP gate
+    {"ecr", Gatetypes::clifford},  // ECR Gate


Hi, I am a junior in the realm of Quantum, Just out of curiosity, Is ECR gate a clifford gate ?

enum-class · 2024-05-23T03:54:06Z

src/simulators/extended_stabilizer/extended_stabilizer_state.hpp

+    BaseState::qreg_.apply_h(op.qubits[1], rank);
+    BaseState::qreg_.apply_cx(op.qubits[0], op.qubits[1], rank);
+    BaseState::qreg_.apply_x(op.qubits[0], rank);
+    BaseState::qreg_.apply_x(op.qubits[1], rank);


This implementation differs to ecr by a -pi/4 global phase. is it generally ok ?

If I am not mistaken this one doesn't have phase difference

qc.h(1)
qc.cx(0, 1)
qc.t(1)
qc.cx(0, 1)
qc.x(0)
qc.cx(0, 1)
qc.tdg(1)
qc.cx(0, 1)
qc.h(1)

I coped from stabilizer

qiskit-aer/src/simulators/stabilizer/stabilizer_state.hpp

Lines 389 to 397 in b706ee1

case Gates::ecr:

BaseState::qreg_.append_h(op.qubits[1]);

BaseState::qreg_.append_s(op.qubits[0]);

BaseState::qreg_.append_z(op.qubits[1]); // sdg(1)

BaseState::qreg_.append_s(op.qubits[1]); // sdg(1)

BaseState::qreg_.append_h(op.qubits[1]);

BaseState::qreg_.append_cx(op.qubits[0], op.qubits[1]);

BaseState::qreg_.append_x(op.qubits[0]);

BaseState::qreg_.append_x(op.qubits[1]);

But it seems it was not correct, ad I get correct circuit by using transpiler

from qiskit import transpile from qiskit import QuantumCircuit from qiskit_aer import AerSimulator sim = AerSimulator(basis_gates = ["h", "cx", "x", "s", "z"]) qc = QuantumCircuit(2) qc.ecr(0, 1) qc = transpile(qc,backend=sim,optimization_level=0) qc.draw('mpl')

I will fix by using this circuit

zlatko-minev · 2024-05-29T14:09:49Z

Great thank you

* Add support for ECR gate * replace is not to != * fix release note * Fix ecr implementation for stabilizer/extended-stabilizer

* release 0.14.2 * Disable test shot_branching on MacOS (#2143) * remove test_shot_branching * disable sho_branching tests on MacOS * fix test * fix test * format * fix test_shot_branching * fix test_runtime_parameterization * fix tests for the latest Qiskit (#2138) * Remove qiskit aer translation stage (#2142) This commit removes the qiskit aer translation plugin. This was added as a workaround for a Qiskit/qiskit#11351. This has been fixed in Qiskit since 0.45.2 and is no longer necessary. The mechanism by which the workaround worked was unsound in practice as it was mutating the target and also explicitly using private attributes of the Target. This is causing real issues now as it only worked by assuming the target wasn't shared between passmanagers which is never guaranteed. Similarly the reliance on internal private attributes of the Target class will cause issues in the future when the target internals change (see Qiskit/qiskit#12292). This commit opts to remove the plugin in its entirity as it's no longer necessary and actively causing issues with Qiskit 1.1 and transpiling targeting aer backends with >1 circuit. As it's private internal detail there isn't a release note. Fixes Qiskit/qiskit#12425 Fixes #2141 * Fix issue 2084 again (#2119) * Fix issue 2084 again * format * fix test * fix test * Always hook omp functions in Mac (#2128) * always hook omp functions in Mac * fix recent test failures with the latest qiskit --------- Co-authored-by: Jun Doi <doichan@jp.ibm.com> * Add simulator_metadata in metadata of SamplerV2 (#2109) Co-authored-by: Hiroshi Horii <hhorii@users.noreply.github.com> * Fix cuStateVec_enable option (#2146) * Fix cuStateVec_enable option * fix function name * Add support for rotation gates (#2147) * add rotation gates * add cr* gates to operations.hpp * fix test for stabilkize/extended-stabilizer * fix test again * Fix deterministic measure of stabilizer (#2132) * Fix deterministic measure of stabilizer * fix accumulation in loop * format --------- Co-authored-by: Hiroshi Horii <hhorii@users.noreply.github.com> * Fix init of EstimatorV2 and SamplerV2 (#2120) * fix init of EstimatorV2 and SamplerV2 to handle method * add release note * fix from_backend and example in README * remove setting density_matrix * Fix deploy.yml (#2110) Co-authored-by: Hiroshi Horii <hhorii@users.noreply.github.com> Co-authored-by: Luciano Bello <bel@zurich.ibm.com> * Add support for ECR gate to MPS (#2137) * Add support for ECR gate * replace is not to != * fix release note * Fix ecr implementation for stabilizer/extended-stabilizer * Handle gates with ctrl_stete=0 (#2148) * handle cx gate with ctrl_stete=0 * add handling *_o0, add test for cx_o0 * format * fix test * fix test * fix test cx * fix to handle multiple control states * fix ctrl_state * format * resolve conflict again * fix aer_compiler * fix random seed (#2151) Co-authored-by: Hiroshi Horii <hhorii@users.noreply.github.com> * Move delay gate to custom instructions (#2153) --------- Co-authored-by: Matthew Treinish <mtreinish@kortar.org> Co-authored-by: Hiroshi Horii <hhorii@users.noreply.github.com> Co-authored-by: Luciano Bello <bel@zurich.ibm.com> Co-authored-by: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com>

Add support for ECR gate

0b34234

doichanj added stable-backport-potential The issue or PR might be minimal and/or import enough to backport to stable Changelog: New Feature Include in the Added section of the changelog Changelog: Bugfix Include in the Fixed section of the changelog labels May 13, 2024

Merge remote-tracking branch 'upstream/main' into fix_2118

14249e0

doichanj requested a review from hhorii May 13, 2024 06:55

doichanj added 4 commits May 13, 2024 16:02

replace is not to !=

332400f

fix release note

c49d05d

Merge remote-tracking branch 'upstream/main' into fix_2118

908e7a2

Merge remote-tracking branch 'upstream/main' into fix_2118

b754ccc

enum-class reviewed May 23, 2024

View reviewed changes

doichanj mentioned this pull request May 23, 2024

Release 0.14.2 #2145

Merged

Fix ecr implementation for stabilizer/extended-stabilizer

65bfb37

hhorii previously approved these changes May 24, 2024

View reviewed changes

resolve conflicts

108ffaa

doichanj dismissed hhorii’s stale review via 108ffaa May 28, 2024 08:37

doichanj requested a review from hhorii May 28, 2024 08:37

hhorii approved these changes May 29, 2024

View reviewed changes

doichanj merged commit 0e7d658 into Qiskit:main May 29, 2024
38 checks passed

doichanj added a commit to doichanj/qiskit-aer that referenced this pull request May 30, 2024

Add support for ECR gate to MPS (Qiskit#2137)

74617c0

* Add support for ECR gate * replace is not to != * fix release note * Fix ecr implementation for stabilizer/extended-stabilizer

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for ECR gate to MPS #2137

Add support for ECR gate to MPS #2137

doichanj commented May 13, 2024 •

edited by 1ucian0

Loading

enum-class May 23, 2024

enum-class May 23, 2024

enum-class May 23, 2024 •

edited

Loading

doichanj May 23, 2024

zlatko-minev commented May 29, 2024

	case Gates::ecr:
	BaseState::qreg_.append_h(op.qubits[1]);
	BaseState::qreg_.append_s(op.qubits[0]);
	BaseState::qreg_.append_z(op.qubits[1]); // sdg(1)
	BaseState::qreg_.append_s(op.qubits[1]); // sdg(1)
	BaseState::qreg_.append_h(op.qubits[1]);
	BaseState::qreg_.append_cx(op.qubits[0], op.qubits[1]);
	BaseState::qreg_.append_x(op.qubits[0]);
	BaseState::qreg_.append_x(op.qubits[1]);

Add support for ECR gate to MPS #2137

Add support for ECR gate to MPS #2137

Conversation

doichanj commented May 13, 2024 • edited by 1ucian0 Loading

Summary

Details and comments

enum-class May 23, 2024

Choose a reason for hiding this comment

enum-class May 23, 2024

Choose a reason for hiding this comment

enum-class May 23, 2024 • edited Loading

Choose a reason for hiding this comment

doichanj May 23, 2024

Choose a reason for hiding this comment

zlatko-minev commented May 29, 2024

doichanj commented May 13, 2024 •

edited by 1ucian0

Loading

enum-class May 23, 2024 •

edited

Loading