Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Commit

Permalink
Fix bad tox.ini passenv setting (#825) (#826)
Browse files Browse the repository at this point in the history
Fixes #821. 

I made a divergence from our testing in qiskit-sphinx-theme to make the INI file more readable, and I didn't properly test it. My bad!

This bug meant that we always used `main` as the branch name. I tested this out locally and it works now:

```
GITHUB_REF_NAME="pull" GITHUB_BASE_REF="upstream" tox -e docs
...
    raise ValueError(GITHUB_BRANCH)
ValueError: upstream
```
  • Loading branch information
Eric-Arellano authored Feb 28, 2024
1 parent 170bd19 commit 8fb6a73
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ setenv =
VIRTUAL_ENV={envdir}
LANGUAGE=en_US
LC_ALL=en_US.utf-8
passenv=
GITHUB_REF_NAME,
passenv =
GITHUB_REF_NAME
GITHUB_BASE_REF
commands =
python -m unittest -v
Expand Down

0 comments on commit 8fb6a73

Please sign in to comment.