This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Split by test type #253
Merged
Split by test type #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daka1510
commented
Mar 4, 2022
| pip install -c constraints.txt -e . | ||
| pip install -U -c constraints.txt -r requirements-dev.txt | ||
| - name: Run Tests | ||
| run: make runtime_integration |
There was a problem hiding this comment.
These tests targeted a file that no longer exists
test/ibm/runtime/test_runtime_integration.py
daka1510
commented
Mar 4, 2022
Comment on lines
36
to
+43
| test1: | ||
| python -m unittest -v test/ibm/test_ibm_backend.py test/ibm/test_account_client.py test/ibm/test_ibm_job_states.py test/ibm/test_tutorials.py test/ibm/test_basic_server_paths.py test/ibm/test_proxies.py test/ibm/test_ibm_integration.py test/ibm/test_ibm_logger.py test/ibm/test_filter_backends.py test/ibm/test_registration.py | ||
| python -m unittest -v test/integration/test_ibm_backend.py test/integration/test_account_client.py test/integration/test_ibm_job_states.py test/integration/test_tutorials.py test/integration/test_basic_server_paths.py test/integration/test_proxies.py test/integration/test_ibm_integration.py test/integration/test_ibm_logger.py test/integration/test_filter_backends.py test/integration/test_registration.py | ||
|
|
||
| test2: | ||
| python -m unittest -v test/ibm/test_ibm_qasm_simulator.py test/ibm/test_serialization.py test/ibm/test_jupyter.py test/ibm/test_composite_job.py test/ibm/test_ibm_provider.py | ||
| python -m unittest -v test/integration/test_ibm_qasm_simulator.py test/integration/test_serialization.py test/integration/test_jupyter.py test/integration/test_composite_job.py test/integration/test_ibm_provider.py | ||
|
|
||
| test3: | ||
| python -m unittest -v test/ibm/test_ibm_job_attributes.py test/ibm/test_ibm_job.py test/ibm/websocket/test_websocket.py test/ibm/websocket/test_websocket_integration.py | ||
| python -m unittest -v test/integration/test_ibm_job_attributes.py test/integration/test_ibm_job.py test/integration/websocket/test_websocket.py test/integration/websocket/test_websocket_integration.py |
There was a problem hiding this comment.
Guess we should migrate this later and get rid of the need to maintain hard-coded lists of file names here. This is easy to do with the new folder structure now.
daka1510
commented
Mar 4, 2022
| @@ -73,37 +73,6 @@ def test_pass_unreachable_proxy(self, qe_token, qe_url): | |||
| IBMProvider(qe_token, qe_url, proxies=proxies) | |||
| self.assertIn("ProxyError", str(context_manager.exception)) | |||
|
|
|||
| def test_provider_init_non_auth_url(self): | |||
There was a problem hiding this comment.
I've split off unit tests from this integration test file and added the removed test cases to a new file within test/unit
daka1510
commented
Mar 4, 2022
| @@ -43,13 +43,13 @@ def setup_test_logging(logger: logging.Logger, filename: str): | |||
| ) | |||
| formatter = logging.Formatter(log_fmt) | |||
|
|
|||
| if os.getenv("STREAM_LOG", "true"): | |||
| if os.getenv("STREAM_LOG", "true").lower() == "true": | |||
There was a problem hiding this comment.
Pull Request Test Coverage Report for Build 1943753443Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Make a clear separation between
unit(that run locally) andintegrationtests (that require configured API credentials). Back-ports parts of Qiskit/qiskit-ibm-runtime#139.Details and comments
In this PR I did neither focus on fixing
integrationtests, nor making a split betweenintegrationande2etests. The main goal is to align the overall structure with the one used inqiskit-ibm-runtimeto ease porting changes required for #237.