Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Enable retrieval of historical data for 'target' #535

Merged
merged 11 commits into from
Mar 9, 2023

Conversation

merav-aharoni
Copy link
Collaborator

@merav-aharoni merav-aharoni commented Mar 7, 2023

Summary

Allow the user to retrieve historical data for the target of the backend.

Details and comments

This is similar to the support that already exists for backend.properties. For target, we defined a new method - target_history, since target is defined as a property.
Note that when we try to pass the datetime parameter to defaults(), it does not work, because there is no support for this parameter on the server side.
See issues #484, #77 .

@merav-aharoni
Copy link
Collaborator Author

@kt474 I implemented usage of datetime in both IBMBackend.target() and IBMBackend.defaults(). However, when I look at the results obtained from a backend (Manila) with a datetime of about a year ago compared to results from now, the results seem identical both for defaults and for target. I think this means something is wrong. However, I have no idea what the problem can be. Can you please have a look?

@coveralls
Copy link

coveralls commented Mar 7, 2023

Pull Request Test Coverage Report for Build 4377155810

  • 2 of 9 (22.22%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 50.077%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_provider/ibm_backend.py 2 9 22.22%
Totals Coverage Status
Change from base Build 4377096380: 0%
Covered Lines: 2942
Relevant Lines: 5875

💛 - Coveralls

@merav-aharoni merav-aharoni changed the title [WIP] Enable retrieval of historical data for 'target' and 'defaults' Enable retrieval of historical data for 'target' Mar 9, 2023
@merav-aharoni merav-aharoni marked this pull request as ready for review March 9, 2023 14:22
@merav-aharoni merav-aharoni requested a review from kt474 March 9, 2023 14:22
Copy link
Member

@kt474 kt474 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - can you add a release note

@merav-aharoni
Copy link
Collaborator Author

Added the release note (had it ready, but forgot to push).

@kt474 kt474 added the Changelog: New Feature Include in the Added section of the changelog label Mar 9, 2023
@kt474 kt474 merged commit dfc4787 into Qiskit:main Mar 9, 2023
@merav-aharoni merav-aharoni deleted the target_history branch March 9, 2023 19:30
@kt474 kt474 added this to the 0.5.0 milestone Mar 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Changelog: New Feature Include in the Added section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants