This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 69
Enable retrieval of historical data for 'target' #535
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kt474 I implemented usage of |
…provider into target_history
Pull Request Test Coverage Report for Build 4377155810
💛 - Coveralls |
kt474
reviewed
Mar 7, 2023
…pported on the server side
merav-aharoni
changed the title
[WIP] Enable retrieval of historical data for 'target' and 'defaults'
Enable retrieval of historical data for 'target'
Mar 9, 2023
kt474
reviewed
Mar 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - can you add a release note
Added the release note (had it ready, but forgot to push). |
kt474
approved these changes
Mar 9, 2023
kt474
added
the
Changelog: New Feature
Include in the Added section of the changelog
label
Mar 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow the user to retrieve historical data for the
target
of thebackend
.Details and comments
This is similar to the support that already exists for
backend.properties
. Fortarget
, we defined a new method -target_history
, sincetarget
is defined as a property.Note that when we try to pass the
datetime
parameter todefaults()
, it does not work, because there is no support for this parameter on the server side.See issues #484, #77 .