Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Fix bug in submitting qasm3 and add tests. #645

Merged
merged 3 commits into from
May 30, 2023
Merged

Fix bug in submitting qasm3 and add tests. #645

merged 3 commits into from
May 30, 2023

Conversation

taalexander
Copy link
Contributor

Summary

Closes #644

Details and comments

@taalexander taalexander requested a review from kt474 May 29, 2023 16:31
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5113805492

  • 5 of 6 (83.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 50.257%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_provider/ibm_backend.py 3 4 75.0%
Totals Coverage Status
Change from base Build 5082667566: 0.02%
Covered Lines: 3036
Relevant Lines: 6041
💛 - Coveralls

kt474
kt474 approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@kt474 kt474 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of this

@kt474 kt474 merged commit 2075b9c into Qiskit:main May 30, 2023
@kt474 kt474 added the Changelog: Bugfix Include in the Fixed section of the changelog label May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kt474 kt474 kt474 approved these changes

Assignees
No one assigned
Labels
Changelog: Bugfix Include in the Fixed section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provider now fails at check_faulty when submitting a qasm3 string with backend.ru
3 participants
@taalexander @coveralls @kt474