Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Use new exclude_params query when retrieving jobs #653

Merged
merged 4 commits into from
Jun 8, 2023

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Jun 6, 2023

Summary

fixes #635

Details and comments

@kt474 kt474 requested a review from merav-aharoni June 6, 2023 19:14
@coveralls
Copy link

coveralls commented Jun 6, 2023

Pull Request Test Coverage Report for Build 5203000770

  • 2 of 8 (25.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 51.802%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_provider/api/clients/runtime.py 1 2 50.0%
qiskit_ibm_provider/ibm_backend_service.py 0 1 0.0%
qiskit_ibm_provider/api/rest/program_job.py 1 5 20.0%
Files with Coverage Reduction New Missed Lines %
qiskit_ibm_provider/ibm_backend_service.py 1 15.66%
Totals Coverage Status
Change from base Build 5180398317: -0.03%
Covered Lines: 3133
Relevant Lines: 6048

💛 - Coveralls

Copy link
Collaborator

@merav-aharoni merav-aharoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A couple of questions/comments:

  • Why is the lazy params not used on IQX?
  • Perhaps add to the test loading of the parameters after first getting the job without _params. This will be helpful for users as a usage example.

releasenotes/notes/exclude-params-645aefa765d5bf07.yaml Outdated Show resolved Hide resolved
Co-authored-by: merav-aharoni <merav@il.ibm.com>
@kt474
Copy link
Member Author

kt474 commented Jun 7, 2023

Looks good. A couple of questions/comments:

  • Why is the lazy params not used on IQX?
  • Perhaps add to the test loading of the parameters after first getting the job witho
    ut _params. This will be helpful for users as a usage example.
Screenshot 2023-06-07 at 2 09 19 PM

The exclude_params parameter is brand new - I don't think IQX would need this parameter because they need the circuit/params on the job page, there's no need for lazy loading them.

@kt474 kt474 merged commit d0a39b2 into Qiskit:main Jun 8, 2023
@kt474 kt474 deleted the exclude-params branch June 8, 2023 15:48
@kt474 kt474 added the Changelog: API Change Include in the Changed section of the changelog label Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Changelog: API Change Include in the Changed section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use new exclude_params query when retrieving jobs
3 participants