Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Add reason code to error message #692

Merged
merged 6 commits into from
Aug 8, 2023
Merged

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Aug 6, 2023

Summary

fixes #691

Example:

IBMJobFailureError: 'Job failed: Error code 9999; Internal Error'

Details and comments

@coveralls
Copy link

coveralls commented Aug 6, 2023

Pull Request Test Coverage Report for Build 5789144076

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 51.127%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_provider/job/ibm_circuit_job.py 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
qiskit_ibm_provider/job/ibm_circuit_job.py 1 47.92%
Totals Coverage Status
Change from base Build 5789141926: -0.02%
Covered Lines: 3312
Relevant Lines: 6478

💛 - Coveralls

@kt474 kt474 marked this pull request as ready for review August 7, 2023 19:56
@kt474 kt474 added the Changelog: New Feature Include in the Added section of the changelog label Aug 7, 2023
@kt474
Copy link
Member Author

kt474 commented Aug 7, 2023

@SooluThomas fyi

Copy link
Collaborator

@merav-aharoni merav-aharoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.
Two tiny suggestions.
Also, I think it is worth adding a check to one of the tests where there is an error message, to check the code as well.

@kt474 kt474 merged commit 2c56779 into Qiskit:main Aug 8, 2023
18 checks passed
@kt474 kt474 deleted the show-error-codes branch August 8, 2023 18:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Changelog: New Feature Include in the Added section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request to expose error code along with the error message
3 participants