This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Exceptions should inherit from Terra where suitable #741
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I only identified two such exceptions:
RuntimeJobFailureError
should inheritJobError
, andQpyError
.While reviewing the exceptions, I changed the exception type in the
fake_account_client.py
. I thoughtQiskitBackendNotFoundError
was more suitable here.One question I had was what is the purpose of double inheritance from
IBMError
, e.g.,IBMQpyError(QpyError, IBMError)
?Details and comments
See also Qiskit/qiskit-ibm-runtime#1120.