Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove qiskitrc related code #1023

Closed
kt474 opened this issue Aug 21, 2023 · 4 comments · Fixed by #1121
Closed

Remove qiskitrc related code #1023

kt474 opened this issue Aug 21, 2023 · 4 comments · Fixed by #1121
Labels
enhancement New feature or request
Milestone

Comments

@kt474
Copy link
Member

kt474 commented Aug 21, 2023

In #370 we added a way for users to automatically copy/use their old credentials from qiskit-ibmq-provider in this repo. qiskit-ibmq-provider is now fully deprecated so we no longer need this functionality.

The qiskitrc file credentials were copied over to the new qiskit-ibm.json credentials file.

@kt474 kt474 added the enhancement New feature or request label Aug 21, 2023
@mtreinish
Copy link
Member

Is there actively a reason we need to do this? I feel like leaving the backwards compatibility code in place makes sense since just because we've archived the ibmq project doesn't mean people aren't using it still. Especially since it's still installable and will work.

@merav-aharoni
Copy link
Contributor

I find it confusing from a developer's perspective. I actually used _QISKITRC_CONFIG_FILE in an issue I am working on now, and it took me a while to realize my mistake.
I think we should at least add a comment in the code not to use this. And I think we should deprecate it at some point in the future.

@jyu00
Copy link
Collaborator

jyu00 commented Aug 28, 2023

Is there actively a reason we need to do this? I feel like leaving the backwards compatibility code in place makes sense since just because we've archived the ibmq project doesn't mean people aren't using it still. Especially since it's still installable and will work.

People using ibmq-provider can still use qiskitrc. I think the proposal here is to just stop using qiskitrc in qiskit-ibm-runtime (not deleting it), since it moved to the new file over a year ago.

And I think we should deprecate it at some point in the future.

I thought it was deprecated (with a deprecation warning) when we moved to the json file? 😅

@merav-aharoni
Copy link
Contributor

There was a notification on this in https://github.com/Qiskit/qiskit-ibm-runtime/blob/main/releasenotes/notes/0.1/account-management-b9908e0b62dc1d81.yaml. However, I didn't see a relevant deprecation message in the code. Much of the qiskitrc related code was removed as far back as 2021. It seems we only have some leftovers now.
Do you think we still need to issue a deprecation warning on this, or is it safe to simply remove the related code? @kt474 , @jyu00 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants