Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically publish tutorials to learning platform #1111

Closed
wants to merge 12 commits into from

Conversation

frankharkins
Copy link
Member

@frankharkins frankharkins commented Sep 27, 2023

Summary

This PR uses GitHub actions to automatically publish tutorials to...

Details

The upload script requires each notebook to be in its own folder with any images. This PR also rearranges the tutorial notebooks to this order, and uses redirects to avoid broken links. Removed some unused images in the process.

Version tables currently break the learning platform too, so I've removed these as there's already a qiskit_ibm_runtime.version.get_version_info() in most tutorials.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@frankharkins
Copy link
Member Author

Just waiting on a fix to the learning API, and then we'll need to add the secrets.

@frankharkins frankharkins marked this pull request as ready for review November 7, 2023 14:05
@coveralls
Copy link

coveralls commented Nov 7, 2023

Pull Request Test Coverage Report for Build 6905812838

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 45.979%

Totals Coverage Status
Change from base Build 6905376671: 0.0%
Covered Lines: 2487
Relevant Lines: 5409

💛 - Coveralls

@kt474
Copy link
Member

kt474 commented Nov 9, 2023

@frankharkins what's the status of this PR? Let me know if you need anything from the runtime side

@frankharkins
Copy link
Member Author

@kt474 this PR is ready for review please. If approved, the only other action is to add the secrets, I'll Slack you with more info on that.

@kt474 kt474 requested a review from beckykd November 10, 2023 19:08
Copy link
Member

@kt474 kt474 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good to me - just to make sure, will the tutorials still render correctly in the qiskit org docs? https://qiskit.org/ecosystem/ibm-runtime/

run: |
pip install git+https://github.com/frankharkins/learning-content-tools.git@12a71a904b0283b2ee44b63cd04ab8fe96e0df6f#subdirectory=iql-lesson-sync
cd docs/tutorials
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this repo be in the qiskit org? Seems a bit odd to have to install something from your personal repo

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's true, I'll look into it. Is it a requirement for this PR?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the tools live in qiskit/documentation? I agree this is an issue for sustainability - it's high bus factor.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the tools live in qiskit/documentation?

That works for me!

@kt474 kt474 requested a review from Eric-Arellano November 10, 2023 19:17
@frankharkins
Copy link
Member Author

will the tutorials still render correctly in the qiskit org docs? https://qiskit.org/ecosystem/ibm-runtime/

Yes, only difference is they'll be at /tutorials/<name>/index.html rather than /tutorials/<name>.html. I've added redirects for the old URLs.

.github/workflows/push-tutorials-to-staging.yml Outdated Show resolved Hide resolved
run: |
pip install git+https://github.com/frankharkins/learning-content-tools.git@12a71a904b0283b2ee44b63cd04ab8fe96e0df6f#subdirectory=iql-lesson-sync
cd docs/tutorials
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the tools live in qiskit/documentation? I agree this is an issue for sustainability - it's high bus factor.

docs/conf.py Outdated Show resolved Hide resolved
docs/conf.py Outdated Show resolved Hide resolved
docs/tutorials/iql.conf.yaml Show resolved Hide resolved
frankharkins and others added 4 commits November 13, 2023 18:15
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Relative links will not work on the learning platform as they don't get resolved to the real urls
@frankharkins frankharkins marked this pull request as draft November 17, 2023 16:50
frankharkins added a commit to Qiskit/documentation that referenced this pull request Nov 17, 2023
This moves a custom tool from
https://github.com/frankharkins/learning-content-tools to this repo as
per
[request](Qiskit/qiskit-ibm-runtime#1111 (comment)).

This tool is not actually used in this repo, it will just live here to
be owned by the Qiskit organisation.

---------

Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
@kt474
Copy link
Member

kt474 commented Dec 4, 2023

Should this work be moved over to https://github.com/Qiskit/documentation/issues now that the docs have been removed from this repo?

@Eric-Arellano
Copy link
Collaborator

My understanding is that the Learning tutorials will still live in this repository, including so that we can test them in CI more easily.

@kt474
Copy link
Member

kt474 commented Mar 29, 2024

Going to close this for now, feel free to reopen

@kt474 kt474 closed this Mar 29, 2024
frankharkins added a commit to frankharkins/documentation that referenced this pull request Jul 22, 2024
This moves a custom tool from
https://github.com/frankharkins/learning-content-tools to this repo as
per
[request](Qiskit/qiskit-ibm-runtime#1111 (comment)).

This tool is not actually used in this repo, it will just live here to
be owned by the Qiskit organisation.

---------

Co-authored-by: Eric Arellano <14852634+Eric-Arellano@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants