Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration guide for IBMBackend.run #1214
Migration guide for IBMBackend.run #1214
Changes from 30 commits
d211315
1872ca0
f550d87
ccf0633
ea899ec
6b6f247
295f0fb
26dcec3
9d0038a
8d7c35a
470da63
d0ab583
61b1de6
7ebbf12
8d0de3f
1f0ff3d
25d6e45
64dba83
ada27f2
23092ff
1e9b641
8879a2d
9521be6
fc6f69d
23a16de
5ead385
fcf0372
57de435
2f1814e
e7454bd
c6631e5
caa648a
8a65ddc
19108ad
c18447b
1b25cbb
f10e366
65c9c6c
96ba7b3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"that performed their own transpilation" doesn't sound right. Maybe "...that had to be manually transpiled..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a short introduction here? It should explain qiskit_ibm_provider vs qiskit_ibm_runtime and why you need to migrate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added. Please have a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's best not to talk about "current" and "future", since those statements quickly go stale, and there's really nothing a user can do with that information right now anyway. We'll just update the information when the code is changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand what makes job2 run outside the session. Is it just 'kicked out' of the session because it uses backend.run? Why would it have a session_id (from the print command) if it runs outside the session?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added an explanation and comments in the code. Please check if they are helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly, I don't understand why this runs outside the session. Is it because it was instantiated with backend.open_session(), so that session just won't accept jobs that don't use backend.run?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above.