Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to qiskit 1.1 #1700

Merged
merged 1 commit into from
May 29, 2024
Merged

Bump to qiskit 1.1 #1700

merged 1 commit into from
May 29, 2024

Conversation

t-imamichi
Copy link
Member

@t-imamichi t-imamichi commented May 22, 2024

Summary

Bump to Qiskit 1.1 and replace Backend Primitives V2 with those of Qiskit 1.1

TODO: We need to take a benchmark using the local mode just in case

Details and comments

Fixes #1631
Fixes #1690
Fixes #1702
Closes #1678

@ihincks
Copy link
Collaborator

ihincks commented May 22, 2024

In order to fully close #1690, we'll need to do things like stop using make_data_bin and _FIELDS. We could also descope that issue, open a new one, and make those changes in a different PR.

@t-imamichi t-imamichi marked this pull request as draft May 22, 2024 14:09
@t-imamichi
Copy link
Member Author

Thank you for pointing out them, Ian. I should have made a PR carefully. I will take a look at those items and identify whether I can include them in this PR or I need a separate PR.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9192822147

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 82.212%

Totals Coverage Status
Change from base Build 9184945052: -0.5%
Covered Lines: 5990
Relevant Lines: 7286

💛 - Coveralls

@kt474
Copy link
Member

kt474 commented May 22, 2024

Thank you for pointing out them, Ian. I should have made a PR carefully. I will take a look at those items and identify whether I can include them in this PR or I need a separate PR.

Let me know if I can help with some of the work that needs to be split out into a separate PR

@ihincks
Copy link
Collaborator

ihincks commented May 22, 2024

I think it will be cleanest if we have 1) this PR, 2) a PR for DataBin access (_FIELDS -> keys() etc), 3) stop using make_data_bin (possible encoder changes).

@ihincks
Copy link
Collaborator

ihincks commented May 22, 2024

I've de-scoped #1690 and added #1702, #1703, #1704.

This PR now closes #1690 and #1702 (as well as the other two listed at the top).

@kt474 all of these can be listed in this sprint, so please feel free to take either or both of the last ones, if you'd like :)

@t-imamichi t-imamichi marked this pull request as ready for review May 23, 2024 02:39
@t-imamichi
Copy link
Member Author

Thank you for reorganizing issues. I updated the description to align them. I think this PR should focus on #1702.
I will work on the other items as separate PRs.

Copy link
Collaborator

@ihincks ihincks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look correct to me, thank you.

@kt474 kt474 merged commit cf64858 into Qiskit:main May 29, 2024
20 checks passed
@kt474 kt474 added the Changelog: New Feature Include in the Added section of the changelog label May 29, 2024
@t-imamichi t-imamichi deleted the qiskit-1.1 branch May 30, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: New Feature Include in the Added section of the changelog
Projects
None yet
4 participants