Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add refresh method to fake backends #1740
Add refresh method to fake backends #1740
Changes from 23 commits
30335d0
55a12fd
3143210
be56edd
ca82d05
371d85c
50dc96f
1992ec6
af4e30c
41e6293
b4ace3c
01dcf0e
0d21fc3
be2c56f
c1f1395
ae8773b
0f3f9c2
334a237
42665b1
3009b24
957f716
40391b6
58c3802
685dcd7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we really rely on the
version
? I don't think it gets updated every time new calibration is pushed. And why even check the version if the server side data is already the freshest.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just updates the files but doesn't actually refresh the
target
if it's already built since it's cached.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should raise an exception or at least a warning. Info level log doesn't get surfaced by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite understand this test. If FakeSherbrooke currently has version 1. The server data has version 2. If the
refresh()
code is not working correctly, bothold_backend
andnew_backend
would remain at version 1, and the test would still pass.