Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate optimization_level #1748

Merged
merged 4 commits into from
Jun 17, 2024
Merged

Deprecate optimization_level #1748

merged 4 commits into from
Jun 17, 2024

Conversation

jyu00
Copy link
Collaborator

@jyu00 jyu00 commented Jun 13, 2024

Summary

Deprecate optimization_level from EstimatorV2. Also update the docstring as the server default is changed to 0.

Details and comments

Fixes #

@coveralls
Copy link

coveralls commented Jun 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9506497735

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 82.304%
Totals Coverage Status
Change from base Build 9504829260: 0.005%
Covered Lines: 6037
Relevant Lines: 7335
💛 - Coveralls

@jyu00 jyu00 requested review from kt474 and ptristan3 June 13, 2024 20:59
@coveralls
Copy link

coveralls commented Jun 13, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9506673649

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 82.304%
Totals Coverage Status
Change from base Build 9504829260: 0.005%
Covered Lines: 6037
Relevant Lines: 7335
💛 - Coveralls

@kt474 kt474 merged commit 31b0141 into Qiskit:main Jun 17, 2024
20 checks passed
@kt474 kt474 added the Changelog: Deprecation Include in Deprecated section of changelog label Jul 3, 2024
@yaelbh yaelbh mentioned this pull request Jul 28, 2024
Closed
@jyu00 jyu00 deleted the deprecate-opt-level branch October 23, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptristan3 ptristan3 ptristan3 approved these changes

@kt474 kt474 kt474 approved these changes

Assignees
No one assigned
Labels
Changelog: Deprecation Include in Deprecated section of changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jyu00 @coveralls @kt474 @ptristan3