Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set _active flag to false if session already closed #1780

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Set _active flag to false if session already closed #1780

merged 4 commits into from
Jul 3, 2024

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Jun 28, 2024 •
edited
Loading

Summary

If the session created with from_id is already closed, jobs should be rejected immediately.

Details and comments

Fixes #1597

@coveralls
Copy link

coveralls commented Jun 28, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9716475964

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 82.076%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_runtime/session.py 2 3 66.67%
Totals Coverage Status
Change from base Build 9715853171: -0.006%
Covered Lines: 6113
Relevant Lines: 7448
💛 - Coveralls

@kt474 kt474 requested review from ptristan3 and SamFerracin July 1, 2024 15:28
SamFerracin
SamFerracin reviewed Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@SamFerracin SamFerracin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add tests for this?

@kt474 kt474 requested a review from SamFerracin July 3, 2024 00:21
@coveralls
Copy link

coveralls commented Jul 3, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9769768037

Details

  • 2 of 3 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 82.178%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_runtime/session.py 2 3 66.67%
Totals Coverage Status
Change from base Build 9749693234: -0.007%
Covered Lines: 6119
Relevant Lines: 7446
💛 - Coveralls

@Qiskit Qiskit deleted a comment from coveralls Jul 3, 2024
@kt474 kt474 merged commit 040f8af into Qiskit:main Jul 3, 2024
18 checks passed
@kt474 kt474 deleted the set-active-flag-session branch July 3, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamFerracin SamFerracin SamFerracin approved these changes

@ptristan3 ptristan3 Awaiting requested review from ptristan3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set _active flag in Session.from_id()
3 participants
@kt474 @coveralls @SamFerracin