Add "private" environment option #1888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kt474
added
the
Changelog: New Feature
ptristan3
approved these changes
Sep 3, 2024
|
Does this work for the cloud channel? I don't see a |
Looks like it doesn't blow up, but probably doesn't do anything either. If this isn't supported for the cloud channel, shouldn't the docs mention that? |
Yeah it's not supported for the cloud channel - I can update the docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
privateas an environment option to mark jobs as privateAlso updated the unit tests in
test_jobto returnRuntimeJobV2since V1 was fully removed.Details and comments
Fixes #1811