Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate simulator noise_model option #1892

Merged
merged 3 commits into from
Aug 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions qiskit_ibm_runtime/base_primitive.py
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,16 @@ def _run(self, pubs: Union[list[EstimatorPub], list[SamplerPub]]) -> RuntimeJobV

logger.info("Submitting job using options %s", primitive_options)

if not isinstance(self._service, QiskitRuntimeLocalService):
if primitive_options.get("options", {}).get("simulator", {}).get("noise_model"):
issue_deprecation_msg(
msg="The noise_model option is deprecated",
version="0.29.0",
remedy="Use the local testing mode instead.",
period="3 months",
stacklevel=3,
)

# Batch or Session
if self._mode:
return self._mode.run(
Expand Down
2 changes: 2 additions & 0 deletions release-notes/unreleased/1892.deprecation.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
The simulator option ``noise_model`` is now deprecated for jobs running on real devices.
``noise_model`` will still be an acceptable option when using the local testing mode.