Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare to publish Spanish and Japanese runtime docs #421

Merged
merged 2 commits into from
Jul 14, 2022
Merged

Prepare to publish Spanish and Japanese runtime docs #421

merged 2 commits into from
Jul 14, 2022

Conversation

SooluThomas
Copy link
Member

@SooluThomas SooluThomas commented Jul 14, 2022 •
edited
Loading

Summary

This PR adds a language selector button to switch between translated docs

Details and comments

Fixes #

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2670609704

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 62.412%
Totals Coverage Status
Change from base Build 2664469362: 0.0%
Covered Lines: 2851
Relevant Lines: 4568
💛 - Coveralls

@SooluThomas SooluThomas marked this pull request as ready for review July 14, 2022 16:00
@SooluThomas SooluThomas changed the title [on hold] Prepare to publish Spanish and Japanese runtime docs Prepare to publish Spanish and Japanese runtime docs Jul 14, 2022
rathishcholarajan
rathishcholarajan approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@rathishcholarajan rathishcholarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @SooluThomas!

@rathishcholarajan rathishcholarajan merged commit 3340ad1 into Qiskit:main Jul 14, 2022
@rathishcholarajan rathishcholarajan modified the milestone: 0.7.0 Jul 14, 2022
@rathishcholarajan rathishcholarajan added the Changelog: New Feature Include in the Added section of the changelog label Jul 14, 2022
@SooluThomas SooluThomas deleted the patch-1 branch July 14, 2022 20:34
SooluThomas added a commit to SooluThomas/qiskit-ibm-runtime that referenced this pull request Jul 14, 2022
@SooluThomas
Prepare to publish Spanish and Japanese runtime docs (Qiskit#421)
347c379 
* publish Spanish and Japanese runtime docs

* fix typo

(cherry picked from commit 3340ad1)
@SooluThomas SooluThomas mentioned this pull request Jul 14, 2022
Closed
SooluThomas added a commit to SooluThomas/qiskit-ibm-runtime that referenced this pull request Jul 14, 2022
@SooluThomas
Prepare to publish Spanish and Japanese runtime docs (Qiskit#421)
a965ff4 
* publish Spanish and Japanese runtime docs

* fix typo

(cherry picked from commit 3340ad1)
@SooluThomas SooluThomas mentioned this pull request Jul 14, 2022
Merged
rathishcholarajan pushed a commit that referenced this pull request Jul 14, 2022
@SooluThomas
Prepare to publish Spanish and Japanese runtime docs (#421) (#425)
9c93582 
* publish Spanish and Japanese runtime docs

* fix typo

(cherry picked from commit 3340ad1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rathishcholarajan rathishcholarajan rathishcholarajan approved these changes

Assignees
No one assigned
Labels
Changelog: New Feature Include in the Added section of the changelog
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@SooluThomas @coveralls @rathishcholarajan