Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qpy 0.21.2 updates #541

Merged
merged 3 commits into from
Sep 29, 2022
Merged

Qpy 0.21.2 updates #541

merged 3 commits into from
Sep 29, 2022

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Sep 22, 2022 •
edited
Loading

Summary

co authored by Jake Lishman and Alexander Ivrii
Qiskit/qiskit#8571
Qiskit/qiskit#7966

Details and comments

Fixes #

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3102327206

  • -8 of 9 (11.11%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 64.392%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_runtime/qpy/binary_io/circuits.py 1 9 11.11%
Files with Coverage Reduction New Missed Lines %
qiskit_ibm_runtime/qpy/binary_io/circuits.py 1 48.09%
Totals Coverage Status
Change from base Build 3100068626: 0.2%
Covered Lines: 3275
Relevant Lines: 5086
💛 - Coveralls

@coveralls
Copy link

coveralls commented Sep 22, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3151784703

  • 1 of 9 (11.11%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 64.977%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_runtime/qpy/binary_io/circuits.py 1 9 11.11%
Files with Coverage Reduction New Missed Lines %
qiskit_ibm_runtime/qpy/binary_io/circuits.py 1 48.09%
Totals Coverage Status
Change from base Build 3136627504: 0.2%
Covered Lines: 3321
Relevant Lines: 5111
💛 - Coveralls

jyu00
jyu00 approved these changes Sep 29, 2022
View reviewed changes
Copy link
Collaborator

@jyu00 jyu00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kt474 kt474 merged commit 0d1cb83 into Qiskit:main Sep 29, 2022
@kt474 kt474 deleted the qpy-0.21.2-updates branch September 29, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyu00 jyu00 jyu00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kt474 @coveralls @jyu00