Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add callback to primitive interface #550

Merged
merged 3 commits into from
Oct 3, 2022
Merged

Add callback to primitive interface #550

merged 3 commits into from
Oct 3, 2022

Conversation

jyu00
Copy link
Collaborator

@jyu00 jyu00 commented Oct 2, 2022

Summary

Allow users to specify a callback function to stream interim results, such as error mitigation progress, of primitives.

Details and comments

Fixes #504

@jyu00 jyu00 requested a review from kt474 October 2, 2022 22:04
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3170271054

  • 0 of 7 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 64.977%
Totals Coverage Status
Change from base Build 3151930372: 0.3%
Covered Lines: 3321
Relevant Lines: 5111
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3170271054

  • 7 of 7 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 64.977%
Totals Coverage Status
Change from base Build 3151930372: 0.3%
Covered Lines: 3321
Relevant Lines: 5111
💛 - Coveralls

kt474
kt474 approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@kt474 kt474 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jyu00 jyu00 merged commit be66ba9 into Qiskit:main Oct 3, 2022
@jyu00 jyu00 deleted the primitive-callback branch October 3, 2022 14:21
@jyu00 jyu00 added the Changelog: New Feature Include in the Added section of the changelog label Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt474 kt474 kt474 approved these changes

Assignees
No one assigned
Labels
Changelog: New Feature Include in the Added section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add callback to primitive interface
3 participants
@jyu00 @coveralls @kt474