Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove excess options #566

Merged
merged 7 commits into from
Oct 10, 2022
Merged

Remove excess options #566

merged 7 commits into from
Oct 10, 2022

Conversation

jyu00
Copy link
Collaborator

@jyu00 jyu00 commented Oct 7, 2022

Summary

After talking to @tmittal947 we decided to keep the number of options to a minimum, in order to keep the interface simple.

Note that this is based on #565, so that one should be reviewed/merged first.

Details and comments

Fixes #

@coveralls
Copy link

coveralls commented Oct 7, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3211307146

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 65.566%
Totals Coverage Status
Change from base Build 3208402811: -0.05%
Covered Lines: 3376
Relevant Lines: 5149
💛 - Coveralls

@jyu00 jyu00 requested a review from kt474 October 10, 2022 02:39
kt474
kt474 approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@kt474 kt474 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt474 kt474 merged commit cfadd6f into Qiskit:main Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt474 kt474 kt474 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jyu00 @coveralls @kt474