Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acceptance Criteria for Authentication Epic #58

Merged

Conversation

rathishcholarajan
Copy link
Member

Summary

I've added acceptance criteria for the Runtime 0.1 - Authentication #2 epic. Will update this file for other epics in separate PRs.

Details and comments

Fixes #

Copy link
Collaborator

@daka1510 daka1510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this up. Matches my understanding. Looks good.

@jyu00
Copy link
Collaborator

jyu00 commented Dec 13, 2021

Questions about save_account

  1. The examples only show save_account with instance explicitly specified. Presumably that parameter is optional?
  2. For legacy runtime, save_account(instance="hgp1") means hgp1 will be the default h/g/p to use, right? But the actual h/g/p used is inferred from the backend selected (e.g. if I want to run on backend1 which is only accessible under hgp2, not hgp1, hgp2 will be used?
  3. Similar to above, except for cloud runtime, whatever instance I've saved will always be used?
  4. If I do save_account() for a name that already exists but with different values (e.g. different instance), it'd essentially update that entry?
  5. IBMRuntimeService() will use legacy, not cloud, account if I only have legacy account saved, right?

@rathishcholarajan
Copy link
Member Author

rathishcholarajan commented Dec 14, 2021

Questions about save_account

  1. The examples only show save_account with instance explicitly specified. Presumably that parameter is optional?

Yes it’s optional. Will add another example.

  1. For legacy runtime, save_account(instance="hgp1") means hgp1 will be the default h/g/p to use, right? But the actual h/g/p used is inferred from the backend selected (e.g. if I want to run on backend1 which is only accessible under hgp2, not hgp1, hgp2 will be used?

Correct. I’ll make a note about it.

  1. Similar to above, except for cloud runtime, whatever instance I've saved will always be used?

Correct.

  1. If I do save_account() for a name that already exists but with different values (e.g. different instance), it'd essentially update that entry?

Correct. Will mention that with an example.

  1. IBMRuntimeService() will use legacy, not cloud, account if I only have legacy account saved, right?

Correct. Will add an example.

Copy link
Collaborator

@daka1510 daka1510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side. We can run another sanity check once this PR and #66 are integrated.

@rathishcholarajan rathishcholarajan merged commit a32d00e into Qiskit:main Jan 5, 2022
@rathishcholarajan rathishcholarajan deleted the acceptance-criteria branch January 5, 2022 08:24
blakejohnson pushed a commit to blakejohnson/qiskit-ibm-runtime that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants